Re: [PATCH] iio/chemical/bme680: Fix SPI read interface

2019-02-20 Thread Jonathan Cameron
On Mon, 18 Feb 2019 07:03:10 + Mike Looijmans wrote: > On 16-02-19 12:27, Himanshu Jha wrote: > > Hello Mike, > > > > On Fri, Feb 15, 2019 at 02:47:55PM +0100, Mike Looijmans wrote: > >> The SPI interface implementation was completely broken. > > > > My apologies! > > > > SPI

Re: [PATCH] iio/chemical/bme680: Fix SPI read interface

2019-02-20 Thread Jonathan Cameron
.. > > Report temperature in millidegrees Celcius instead of degrees. > > Jonathan, I didn't know about this but is there any rationale to report > in millidegress ? Misguided attempt in the early days of IIO to match hwmon units. Sadly it is now the ABI and hence 'unfixable'. Same odd units

Re: [PATCH] iio/chemical/bme680: Fix SPI read interface

2019-02-17 Thread Mike Looijmans
On 16-02-19 12:27, Himanshu Jha wrote: > Hello Mike, > > On Fri, Feb 15, 2019 at 02:47:55PM +0100, Mike Looijmans wrote: >> The SPI interface implementation was completely broken. > > My apologies! > > SPI interface caused me a lot of trouble in my project timeline. I tried > many different

Re: [PATCH] iio/chemical/bme680: Fix SPI read interface

2019-02-16 Thread Himanshu Jha
Hello Mike, On Fri, Feb 15, 2019 at 02:47:55PM +0100, Mike Looijmans wrote: > The SPI interface implementation was completely broken. My apologies! SPI interface caused me a lot of trouble in my project timeline. I tried many different ways to try playing with acpi dsl, printks etc. One of the

[PATCH] iio/chemical/bme680: Fix SPI read interface

2019-02-15 Thread Mike Looijmans
The SPI interface implementation was completely broken. When using the SPI interface, there are only 7 address bits, the upper bit is controlled by a page select register. The core needs access to both ranges, so implement register read/write for both regions. The regmap paging functionality