Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-08-15 Thread Guenter Roeck
Hi Jonathan, On Mon, Aug 15, 2016 at 07:04:31PM +0100, Jonathan Cameron wrote: > On 26/07/16 04:22, Guenter Roeck wrote: > > On 07/25/2016 07:51 PM, Caesar Wang wrote: > >> Hi Guenter, > >> > >> Thanks for fixing it. > >> > >> On 2016年07月26日 03:39, Guenter Roeck wrote: > >>> If the ADC is read

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-08-15 Thread Guenter Roeck
Hi Jonathan, On Mon, Aug 15, 2016 at 07:04:31PM +0100, Jonathan Cameron wrote: > On 26/07/16 04:22, Guenter Roeck wrote: > > On 07/25/2016 07:51 PM, Caesar Wang wrote: > >> Hi Guenter, > >> > >> Thanks for fixing it. > >> > >> On 2016年07月26日 03:39, Guenter Roeck wrote: > >>> If the ADC is read

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-08-15 Thread Jonathan Cameron
On 26/07/16 04:22, Guenter Roeck wrote: > On 07/25/2016 07:51 PM, Caesar Wang wrote: >> Hi Guenter, >> >> Thanks for fixing it. >> >> On 2016年07月26日 03:39, Guenter Roeck wrote: >>> If the ADC is read for the first time, the caller gets a timeout error, >>> and the kernel log shows >>> >>> read

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-08-15 Thread Jonathan Cameron
On 26/07/16 04:22, Guenter Roeck wrote: > On 07/25/2016 07:51 PM, Caesar Wang wrote: >> Hi Guenter, >> >> Thanks for fixing it. >> >> On 2016年07月26日 03:39, Guenter Roeck wrote: >>> If the ADC is read for the first time, the caller gets a timeout error, >>> and the kernel log shows >>> >>> read

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-26 Thread Caesar Wang
On 2016年07月26日 11:22, Guenter Roeck wrote: On 07/25/2016 07:51 PM, Caesar Wang wrote: Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-26 Thread Caesar Wang
On 2016年07月26日 11:22, Guenter Roeck wrote: On 07/25/2016 07:51 PM, Caesar Wang wrote: Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Guenter Roeck
On 07/25/2016 07:51 PM, Caesar Wang wrote: Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Guenter Roeck
On 07/25/2016 07:51 PM, Caesar Wang wrote: Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Caesar Wang
Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be explicitly disabled for a read sequence to

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Caesar Wang
Hi Guenter, Thanks for fixing it. On 2016年07月26日 03:39, Guenter Roeck wrote: If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be explicitly disabled for a read sequence to

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Heiko Stübner
Am Montag, 25. Juli 2016, 12:39:00 schrieb Guenter Roeck: > If the ADC is read for the first time, the caller gets a timeout error, > and the kernel log shows > > read channel() error: -110 > > The ADC may be enabled on boot, and needs to be explicitly disabled > for a read sequence to work

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Heiko Stübner
Am Montag, 25. Juli 2016, 12:39:00 schrieb Guenter Roeck: > If the ADC is read for the first time, the caller gets a timeout error, > and the kernel log shows > > read channel() error: -110 > > The ADC may be enabled on boot, and needs to be explicitly disabled > for a read sequence to work

[PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Guenter Roeck
If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be explicitly disabled for a read sequence to work (otherwise there is no completion interrupt). Disaple it explicitly in the

[PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

2016-07-25 Thread Guenter Roeck
If the ADC is read for the first time, the caller gets a timeout error, and the kernel log shows read channel() error: -110 The ADC may be enabled on boot, and needs to be explicitly disabled for a read sequence to work (otherwise there is no completion interrupt). Disaple it explicitly in the