Re: [PATCH] iio: inkern: fix a static checker error

2017-04-25 Thread Jonathan Cameron
On 24/04/17 10:32, Peter Rosin wrote: > On 2017-04-20 23:13, Peter Rosin wrote: >> On 2017-04-20 23:12, Lars-Peter Clausen wrote: >>> On 04/20/2017 11:01 PM, Peter Rosin wrote: Avoid this smatch error: drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock 'mutex

Re: [PATCH] iio: inkern: fix a static checker error

2017-04-25 Thread Peter Rosin
On 2017-04-25 18:01, Lars-Peter Clausen wrote: > On 04/24/2017 11:32 AM, Peter Rosin wrote: >> On 2017-04-20 23:13, Peter Rosin wrote: >>> On 2017-04-20 23:12, Lars-Peter Clausen wrote: On 04/20/2017 11:01 PM, Peter Rosin wrote: > Avoid this smatch error: > drivers/iio/inkern.c:751 iio

Re: [PATCH] iio: inkern: fix a static checker error

2017-04-25 Thread Lars-Peter Clausen
On 04/24/2017 11:32 AM, Peter Rosin wrote: > On 2017-04-20 23:13, Peter Rosin wrote: >> On 2017-04-20 23:12, Lars-Peter Clausen wrote: >>> On 04/20/2017 11:01 PM, Peter Rosin wrote: Avoid this smatch error: drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock '

Re: [PATCH] iio: inkern: fix a static checker error

2017-04-24 Thread Peter Rosin
On 2017-04-20 23:13, Peter Rosin wrote: > On 2017-04-20 23:12, Lars-Peter Clausen wrote: >> On 04/20/2017 11:01 PM, Peter Rosin wrote: >>> Avoid this smatch error: >>> drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock >>> 'mutex:&chan->indio_dev->info_exist_lock' >> >> Loo

Re: [PATCH] iio: inkern: fix a static checker error

2017-04-20 Thread Peter Rosin
On 2017-04-20 23:12, Lars-Peter Clausen wrote: > On 04/20/2017 11:01 PM, Peter Rosin wrote: >> Avoid this smatch error: >> drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock >> 'mutex:&chan->indio_dev->info_exist_lock' > > Looks good, but it's not just the smatch error, th

Re: [PATCH] iio: inkern: fix a static checker error

2017-04-20 Thread Lars-Peter Clausen
On 04/20/2017 11:01 PM, Peter Rosin wrote: > Avoid this smatch error: > drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock > 'mutex:&chan->indio_dev->info_exist_lock' Looks good, but it's not just the smatch error, this is a real issue. This even seems to be a endless loop

[PATCH] iio: inkern: fix a static checker error

2017-04-20 Thread Peter Rosin
Avoid this smatch error: drivers/iio/inkern.c:751 iio_read_avail_channel_raw() error: double unlock 'mutex:&chan->indio_dev->info_exist_lock' Fixes: 00c5f80c2fad ("iio: inkern: add helpers to query available values from channels") Signed-off-by: Peter Rosin --- drivers/iio/inkern.c | 4 +--- 1