Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 19:02 +0200, Takashi Iwai wrote: > At Tue, 17 Jul 2007 18:48:46 +0200, > Sam Ravnborg wrote: > > > > On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: > > > At Tue, 17 Jul 2007 17:32:36 +0200, > > > Sam Ravnborg wrote: > > > > > > > > On Tue, Jul 17, 2007 at 05:16:13PM

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 17:40 +0200, Takashi Iwai wrote: > At Tue, 17 Jul 2007 17:32:36 +0200, > Sam Ravnborg wrote: > > > > On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: > > > At Tue, 17 Jul 2007 17:14:32 +0200, > > > Sam Ravnborg wrote: > > > > > > > > On Tue, Jul 17, 2007 at 04:52:12PM

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 18:48:46 +0200, Sam Ravnborg wrote: > > On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: > > At Tue, 17 Jul 2007 17:32:36 +0200, > > Sam Ravnborg wrote: > > > > > > On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: > > > > At Tue, 17 Jul 2007 17:14:32

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: > At Tue, 17 Jul 2007 17:32:36 +0200, > Sam Ravnborg wrote: > > > > On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: > > > At Tue, 17 Jul 2007 17:14:32 +0200, > > > Sam Ravnborg wrote: > > > > > > > > On Tue, Jul 17, 2007

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: > > On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: > > At Tue, 17 Jul 2007 17:14:32 +0200, > > Sam Ravnborg wrote: > > > > > > On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > > > > At Tue, 17 Jul 2007 15:02:30

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: > At Tue, 17 Jul 2007 17:14:32 +0200, > Sam Ravnborg wrote: > > > > On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > > > At Tue, 17 Jul 2007 15:02:30 +0200, > > > Sam Ravnborg wrote: > > > > > > > > On Tue, Jul 17, 2007

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: > > On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > > At Tue, 17 Jul 2007 15:02:30 +0200, > > Sam Ravnborg wrote: > > > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > > > Introduce __init_exit, which

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: > At Tue, 17 Jul 2007 15:02:30 +0200, > Sam Ravnborg wrote: > > > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > > Introduce __init_exit, which is useful ie. for drivers that call > > > cleanup functions when they

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 15:02:30 +0200, Sam Ravnborg wrote: > > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > Introduce __init_exit, which is useful ie. for drivers that call > > cleanup functions when they fail in __init functions. > > This is wrong. > On arm (just one example

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > Introduce __init_exit, which is useful ie. for drivers that call > cleanup functions when they fail in __init functions. This is wrong. On arm (just one example of several) the __exit section are discarded at buildtime so any

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 10:31 +0200, Adrian Bunk wrote: > On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > > Introduce __init_exit, which is useful ie. for drivers that call > > cleanup functions when they fail in __init functions. > > > > > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> >

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Adrian Bunk
On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: > Introduce __init_exit, which is useful ie. for drivers that call > cleanup functions when they fail in __init functions. > > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > --- > include/linux/init.h |2 ++ > 1 file

[PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- include/linux/init.h |2 ++ 1 file changed, 2 insertions(+) Index: work-powerpc.git/include/linux/init.h

[PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer [EMAIL PROTECTED] --- include/linux/init.h |2 ++ 1 file changed, 2 insertions(+) Index: work-powerpc.git/include/linux/init.h

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Adrian Bunk
On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer [EMAIL PROTECTED] --- include/linux/init.h |2 ++ 1 file changed, 2

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 10:31 +0200, Adrian Bunk wrote: On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. Signed-off-by: Domen Puncer [EMAIL PROTECTED] ---

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. This is wrong. On arm (just one example of several) the __exit section are discarded at buildtime so any reference

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 15:02:30 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in __init functions. This is wrong. On arm (just one example of

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 15:02:30 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie. for drivers that call cleanup functions when they fail in

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 15:02:30 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 10:02:48AM +0200, Domen Puncer wrote: Introduce __init_exit, which is useful ie.

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 15:02:30 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 10:02:48AM

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 15:02:30 +0200, Sam

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Sam Ravnborg
On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 04:52:12PM

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Takashi Iwai
At Tue, 17 Jul 2007 18:48:46 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:14:32 +0200, Sam

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 17:40 +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:14:32 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 04:52:12PM +0200, Takashi Iwai

Re: [PATCH] introduce __init_exit function annotation

2007-07-17 Thread Domen Puncer
On 17/07/07 19:02 +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 18:48:46 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:40:15PM +0200, Takashi Iwai wrote: At Tue, 17 Jul 2007 17:32:36 +0200, Sam Ravnborg wrote: On Tue, Jul 17, 2007 at 05:16:13PM +0200, Takashi Iwai