On 10/28/2016 09:29 PM, Colin Ian King wrote:
On 28/10/16 20:21, Manfred Spraul wrote:
Hi Colin,
On 10/28/2016 08:11 PM, Colin King wrote:
[...]
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1839,7 +1839,7 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct
sembuf __user *, tsops,
max = 0;
On 10/28/2016 09:29 PM, Colin Ian King wrote:
On 28/10/16 20:21, Manfred Spraul wrote:
Hi Colin,
On 10/28/2016 08:11 PM, Colin King wrote:
[...]
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -1839,7 +1839,7 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct
sembuf __user *, tsops,
max = 0;
On Fri, 28 Oct 2016, Colin King wrote:
Thanks.
On Fri, 28 Oct 2016, Colin King wrote:
Thanks.
On 28/10/16 20:21, Manfred Spraul wrote:
> Hi Colin,
>
> On 10/28/2016 08:11 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> The left shift amount is sop->sem_num % 64, which is up to 63, so
>> ensure we are shifting a ULL rather than a 32 bit value.
> Good catch,
On 28/10/16 20:21, Manfred Spraul wrote:
> Hi Colin,
>
> On 10/28/2016 08:11 PM, Colin King wrote:
>> From: Colin Ian King
>>
>> The left shift amount is sop->sem_num % 64, which is up to 63, so
>> ensure we are shifting a ULL rather than a 32 bit value.
> Good catch, thanks.
>> CoverityScan
Hi Colin,
On 10/28/2016 08:11 PM, Colin King wrote:
From: Colin Ian King
The left shift amount is sop->sem_num % 64, which is up to 63, so
ensure we are shifting a ULL rather than a 32 bit value.
Good catch, thanks.
CoverityScan CID#1372862 "Bad bit shift
Hi Colin,
On 10/28/2016 08:11 PM, Colin King wrote:
From: Colin Ian King
The left shift amount is sop->sem_num % 64, which is up to 63, so
ensure we are shifting a ULL rather than a 32 bit value.
Good catch, thanks.
CoverityScan CID#1372862 "Bad bit shift operation"
Fixes: 7c24530cb4e3c0ae
From: Colin Ian King
The left shift amount is sop->sem_num % 64, which is up to 63, so
ensure we are shifting a ULL rather than a 32 bit value.
CoverityScan CID#1372862 "Bad bit shift operation"
Fixes: 7c24530cb4e3c0ae ("ipc/sem: optimize perform_atomic_semop()")
From: Colin Ian King
The left shift amount is sop->sem_num % 64, which is up to 63, so
ensure we are shifting a ULL rather than a 32 bit value.
CoverityScan CID#1372862 "Bad bit shift operation"
Fixes: 7c24530cb4e3c0ae ("ipc/sem: optimize perform_atomic_semop()")
Signed-off-by: Colin Ian King
10 matches
Mail list logo