From: Francois Romieu <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 23:11:19 +0100
> Rainer Jochem <[EMAIL PROTECTED]> :
> [...]
> > --- net/ipv4/ipconfig.c.orig2007-11-14 09:16:15.800566536 +0100
> > +++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100
> > @@ -139,6 +139,8 @@
From: Francois Romieu [EMAIL PROTECTED]
Date: Wed, 14 Nov 2007 23:11:19 +0100
Rainer Jochem [EMAIL PROTECTED] :
[...]
--- net/ipv4/ipconfig.c.orig2007-11-14 09:16:15.800566536 +0100
+++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100
@@ -139,6 +139,8 @@ __be32
Rainer Jochem <[EMAIL PROTECTED]> :
[...]
> --- net/ipv4/ipconfig.c.orig 2007-11-14 09:16:15.800566536 +0100
> +++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100
> @@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE;/* Boot serve
> __be32 root_server_addr = NONE; /* Address
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 10:48:43 +0100
> Rainer Jochem wrote:
> >
> >> I don't think its very useful since you can simply get this information
> >> from /proc/cmdline in case something goes wrong, but if you insist at
> >> least give it a meaningful
Rainer Jochem wrote:
I don't think its very useful since you can simply get this information
from /proc/cmdline in case something goes wrong, but if you insist at
least give it a meaningful prefix.
Added.
The initialization is unnecessary.
Removed.
Should be >= I think.
Fixed.
> I don't think its very useful since you can simply get this information
> from /proc/cmdline in case something goes wrong, but if you insist at
> least give it a meaningful prefix.
Added.
> The initialization is unnecessary.
Removed.
> Should be >= I think.
Fixed.
Regards,
Rainer
Rainer Jochem wrote:
Corrected version below.
+ printk(KERN_INFO "Sending class identifier \"%s\"\n",
+ vendor_class_identifier);
Seems like useless noise.
This information is only sent in the case that the option is actually used.
And in
Corrected version below.
> >+printk(KERN_INFO "Sending class identifier \"%s\"\n",
> >+ vendor_class_identifier);
>
> Seems like useless noise.
This information is only sent in the case that the option is actually used.
And in this case it might be
Corrected version below.
+printk(KERN_INFO Sending class identifier \%s\\n,
+ vendor_class_identifier);
Seems like useless noise.
This information is only sent in the case that the option is actually used.
And in this case it might be useful
Rainer Jochem wrote:
Corrected version below.
+ printk(KERN_INFO Sending class identifier \%s\\n,
+ vendor_class_identifier);
Seems like useless noise.
This information is only sent in the case that the option is actually used.
And in this
I don't think its very useful since you can simply get this information
from /proc/cmdline in case something goes wrong, but if you insist at
least give it a meaningful prefix.
Added.
The initialization is unnecessary.
Removed.
Should be = I think.
Fixed.
Regards,
Rainer
---
Rainer Jochem wrote:
I don't think its very useful since you can simply get this information
from /proc/cmdline in case something goes wrong, but if you insist at
least give it a meaningful prefix.
Added.
The initialization is unnecessary.
Removed.
Should be = I think.
Fixed.
From: Patrick McHardy [EMAIL PROTECTED]
Date: Wed, 14 Nov 2007 10:48:43 +0100
Rainer Jochem wrote:
I don't think its very useful since you can simply get this information
from /proc/cmdline in case something goes wrong, but if you insist at
least give it a meaningful prefix.
Added.
Rainer Jochem [EMAIL PROTECTED] :
[...]
--- net/ipv4/ipconfig.c.orig 2007-11-14 09:16:15.800566536 +0100
+++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100
@@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE;/* Boot serve
__be32 root_server_addr = NONE; /* Address of
On Thu, 8 Nov 2007, Rainer Jochem wrote:
> @@ -620,6 +622,17 @@ ic_dhcp_init_options(u8 *options)
> *e++ = sizeof(ic_req_params);
> memcpy(e, ic_req_params, sizeof(ic_req_params));
> e += sizeof(ic_req_params);
> +
> + // Send it only if the
Rainer Jochem wrote:
--- net/ipv4/ipconfig.c.orig2007-11-08 14:54:11.001662860 +0100
+++ net/ipv4/ipconfig.c 2007-11-08 14:54:15.961480524 +0100
@@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE; /* Boot serve
__be32 root_server_addr = NONE;/* Address of NFS server */
u8
This patch implements the DHCP Class identifier (see rfc1533) which is
used by DHCP clients to optionally identify the type and configuration of
a DHCP client which is send as a string to the server. For example, the
identifier may encode the client's hardware configuration. If the newly
This patch implements the DHCP Class identifier (see rfc1533) which is
used by DHCP clients to optionally identify the type and configuration of
a DHCP client which is send as a string to the server. For example, the
identifier may encode the client's hardware configuration. If the newly
Rainer Jochem wrote:
--- net/ipv4/ipconfig.c.orig2007-11-08 14:54:11.001662860 +0100
+++ net/ipv4/ipconfig.c 2007-11-08 14:54:15.961480524 +0100
@@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE; /* Boot serve
__be32 root_server_addr = NONE;/* Address of NFS server */
u8
On Thu, 8 Nov 2007, Rainer Jochem wrote:
@@ -620,6 +622,17 @@ ic_dhcp_init_options(u8 *options)
*e++ = sizeof(ic_req_params);
memcpy(e, ic_req_params, sizeof(ic_req_params));
e += sizeof(ic_req_params);
+
+ // Send it only if the
20 matches
Mail list logo
