Re: [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph

2019-10-13 Thread kbuild test robot
Hi Joe, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph

2019-10-13 Thread kbuild test robot
Hi Joe, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 19:05 +0300, Andy Shevchenko wrote: > On Fri, Oct 11, 2019 at 08:46:41AM -0700, Joe Perches wrote: > > Using %*ph format to print small buffers as hex string reduces > > overall object size and allows the removal of the two variants > > of ipmi_debug_msg. > > > > This also

Re: [PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph

2019-10-11 Thread Andy Shevchenko
On Fri, Oct 11, 2019 at 08:46:41AM -0700, Joe Perches wrote: > Using %*ph format to print small buffers as hex string reduces > overall object size and allows the removal of the two variants > of ipmi_debug_msg. > > This also removes unnecessary duplicate colons from output when > enabled by

[PATCH] ipmi: Convert ipmi_debug_msg to pr_debug and use %*ph

2019-10-11 Thread Joe Perches
Using %*ph format to print small buffers as hex string reduces overall object size and allows the removal of the two variants of ipmi_debug_msg. This also removes unnecessary duplicate colons from output when enabled by #DEBUG or newly possible CONFIG_DYNAMIC_DEBUG. Suggested-by: Andy Shevchenko