Re: [PATCH] ipv6: include for missing declarations

2019-10-22 Thread Jakub Kicinski
On Tue, 22 Oct 2019 15:44:40 +0100, Ben Dooks (Codethink) wrote:
> Include  for the missing declarations of
> various functions. Fixes the following sparse warnings:
> 
> net/ipv6/addrconf_core.c:94:5: warning: symbol 'register_inet6addr_notifier' 
> was not declared. Should it be static?
> net/ipv6/addrconf_core.c:100:5: warning: symbol 
> 'unregister_inet6addr_notifier' was not declared. Should it be static?
> net/ipv6/addrconf_core.c:106:5: warning: symbol 
> 'inet6addr_notifier_call_chain' was not declared. Should it be static?
> net/ipv6/addrconf_core.c:112:5: warning: symbol 
> 'register_inet6addr_validator_notifier' was not declared. Should it be static?
> net/ipv6/addrconf_core.c:118:5: warning: symbol 
> 'unregister_inet6addr_validator_notifier' was not declared. Should it be 
> static?
> net/ipv6/addrconf_core.c:125:5: warning: symbol 
> 'inet6addr_validator_notifier_call_chain' was not declared. Should it be 
> static?
> net/ipv6/addrconf_core.c:237:6: warning: symbol 'in6_dev_finish_destroy' was 
> not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) 

Applied, thanks!


[PATCH] ipv6: include for missing declarations

2019-10-22 Thread Ben Dooks (Codethink)
Include  for the missing declarations of
various functions. Fixes the following sparse warnings:

net/ipv6/addrconf_core.c:94:5: warning: symbol 'register_inet6addr_notifier' 
was not declared. Should it be static?
net/ipv6/addrconf_core.c:100:5: warning: symbol 'unregister_inet6addr_notifier' 
was not declared. Should it be static?
net/ipv6/addrconf_core.c:106:5: warning: symbol 'inet6addr_notifier_call_chain' 
was not declared. Should it be static?
net/ipv6/addrconf_core.c:112:5: warning: symbol 
'register_inet6addr_validator_notifier' was not declared. Should it be static?
net/ipv6/addrconf_core.c:118:5: warning: symbol 
'unregister_inet6addr_validator_notifier' was not declared. Should it be static?
net/ipv6/addrconf_core.c:125:5: warning: symbol 
'inet6addr_validator_notifier_call_chain' was not declared. Should it be static?
net/ipv6/addrconf_core.c:237:6: warning: symbol 'in6_dev_finish_destroy' was 
not declared. Should it be static?

Signed-off-by: Ben Dooks (Codethink) 
---
Cc: "David S. Miller" 
Cc: Alexey Kuznetsov 
Cc: Hideaki YOSHIFUJI 
Cc: net...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 net/ipv6/addrconf_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/addrconf_core.c b/net/ipv6/addrconf_core.c
index 783f3c1466da..2fc079284ca4 100644
--- a/net/ipv6/addrconf_core.c
+++ b/net/ipv6/addrconf_core.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 /* if ipv6 module registers this function is used by xfrm to force all
-- 
2.23.0