Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-13 Thread Srinivas Kandagatla
On 13/06/18 09:45, Sudeep Holla wrote: On Wed, Jun 13, 2018 at 9:21 AM, Srinivas Kandagatla wrote: On 12/06/18 17:34, Marc Zyngier wrote: I suggest you find out how the GIC has been integrated on this platform. If you take a fault on accessing this register, this very much looks like an

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-13 Thread Sudeep Holla
On Wed, Jun 13, 2018 at 9:21 AM, Srinivas Kandagatla wrote: > > > On 12/06/18 17:34, Marc Zyngier wrote: >> >> I suggest you find out how the GIC has been integrated on this >> platform. If you take a fault on accessing this register, this very >> much looks like an integration bug, and it should

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-13 Thread Srinivas Kandagatla
On 12/06/18 17:34, Marc Zyngier wrote: I suggest you find out how the GIC has been integrated on this platform. If you take a fault on accessing this register, this very much looks like an integration bug, and it should be quirked as such. Thanks for the suggestion, This is a bug in the firmwa

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Marc Zyngier
On Tue, 12 Jun 2018 15:55:16 +0100, Srinivas Kandagatla wrote: > > GICR_WAKER can be a secured register, check this before accessing it > as its done in power management code. NAK. >From the GICv3 spec: * When GICD_CTLR.DS==1, this register is always accessible. * When GICD_CTLR.DS==0, this is

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Srinivas Kandagatla
On 12/06/18 16:24, Sudeep Holla wrote: On Tue, Jun 12, 2018 at 3:55 PM, Srinivas Kandagatla wrote: GICR_WAKER can be a secured register, check this before accessing it as its done in power management code. Without this patch Qualcomm DB820c board crashes. Are you sure this is the one cau

Re: [PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Sudeep Holla
On Tue, Jun 12, 2018 at 3:55 PM, Srinivas Kandagatla wrote: > GICR_WAKER can be a secured register, check this before accessing it > as its done in power management code. > > Without this patch Qualcomm DB820c board crashes. > Are you sure this is the one causing the crash ? As per GIC specifica

[PATCH] irqchip/gic-v3: do not access GICR_WAKER if its secured register.

2018-06-12 Thread Srinivas Kandagatla
GICR_WAKER can be a secured register, check this before accessing it as its done in power management code. Without this patch Qualcomm DB820c board crashes. Signed-off-by: Srinivas Kandagatla --- drivers/irqchip/irq-gic-v3.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-)