Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Uwe Kleine-König wrote: > Hello Thomas, > > On Tue, Mar 12, 2013 at 08:57:34PM +0100, Thomas Gleixner wrote: > > On Tue, 12 Mar 2013, Uwe Kleine-König wrote: > > > +static struct nvic_chip_data nvic_data __read_mostly; > > > > What the heck is this? You have a static struct

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
Hello Thomas, On Tue, Mar 12, 2013 at 08:57:34PM +0100, Thomas Gleixner wrote: > On Tue, 12 Mar 2013, Uwe Kleine-König wrote: > > +static struct nvic_chip_data nvic_data __read_mostly; > > What the heck is this? You have a static struct which you set in > irqdata.chip_data? I copied that idea fro

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 08:27:02PM +0100, Uwe Kleine-König wrote: > On Tue, Mar 12, 2013 at 04:01:01PM +, Russell King - ARM Linux wrote: > > On Tue, Mar 12, 2013 at 04:54:33PM +0100, Uwe Kleine-König wrote: > > > +#include > > > +#include > > > > linux/io.h > > > > > + unsigned int irqs, i

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Thomas Gleixner
On Tue, 12 Mar 2013, Uwe Kleine-König wrote: > +static struct nvic_chip_data nvic_data __read_mostly; What the heck is this? You have a static struct which you set in irqdata.chip_data? > +static inline void __iomem *nvic_dist_base(struct irq_data *d) > +{ > + struct nvic_chip_data *nvic_data

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
On Tue, Mar 12, 2013 at 04:01:01PM +, Russell King - ARM Linux wrote: > On Tue, Mar 12, 2013 at 04:54:33PM +0100, Uwe Kleine-König wrote: > > +#include > > +#include > > linux/io.h > > > + unsigned int irqs, i, irq_base; > > + > > + irq_base = irq_alloc_descs(-1, 16, irqs - 16, numa_nod

[PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Uwe Kleine-König
From: Catalin Marinas This interrupt controller is found on Cortex-M3 and Cortex-M4 machines. [ukleinek: drop locking, switch to fasteoi handler, add irqdomain and dt support, move to drivers/irq] Signed-off-by: Catalin Marinas Signed-off-by: Uwe Kleine-König --- drivers/irqchip/Kconfig|

Re: [PATCH] irqchip: Add support for ARMv7-M's NVIC

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 04:54:33PM +0100, Uwe Kleine-König wrote: > +#include > +#include linux/io.h > + unsigned int irqs, i, irq_base; > + > + irq_base = irq_alloc_descs(-1, 16, irqs - 16, numa_node_id()); > + if (IS_ERR_VALUE(irq_base)) { Erm... irq_alloc_descs() returns a negat