Re: [PATCH] isdn: eicon: fix a missing-check bug

Thanks for your suggestion, David! I will revise the patch and resubmit it. Wenwen On Fri, May 11, 2018 at 2:50 PM, David Miller wrote: > From: Wenwen Wang > Date: Sat, 5 May 2018 14:32:46 -0500 > >> To avoid such issues, this patch adds a check after

Re: [PATCH] isdn: eicon: fix a missing-check bug

Thanks for your suggestion, David! I will revise the patch and resubmit it. Wenwen On Fri, May 11, 2018 at 2:50 PM, David Miller wrote: > From: Wenwen Wang > Date: Sat, 5 May 2018 14:32:46 -0500 > >> To avoid such issues, this patch adds a check after the second copy in the >> function

Re: [PATCH] isdn: eicon: fix a missing-check bug

From: Wenwen Wang Date: Sat, 5 May 2018 14:32:46 -0500 > To avoid such issues, this patch adds a check after the second copy in the > function diva_xdi_write(). If the adapter number is not equal to the one > obtained in the first copy, (-4) will be returned to divas_write(),

Re: [PATCH] isdn: eicon: fix a missing-check bug

From: Wenwen Wang Date: Sat, 5 May 2018 14:32:46 -0500 > To avoid such issues, this patch adds a check after the second copy in the > function diva_xdi_write(). If the adapter number is not equal to the one > obtained in the first copy, (-4) will be returned to divas_write(), which > will then

Re: [PATCH] isdn: eicon: fix a missing-check bug

On Wed, May 09, 2018 at 12:30:18AM -0500, Wenwen Wang wrote: > Hello > > Could you please review this patch? We need a confirmation because we > are working on an approaching deadline. I didn't know 'we' had deadlines :) Tobin

Re: [PATCH] isdn: eicon: fix a missing-check bug

On Wed, May 09, 2018 at 12:30:18AM -0500, Wenwen Wang wrote: > Hello > > Could you please review this patch? We need a confirmation because we > are working on an approaching deadline. I didn't know 'we' had deadlines :) Tobin

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello Could you please review this patch? We need a confirmation because we are working on an approaching deadline. Thanks! Wenwen On Sat, May 5, 2018 at 2:32 PM, Wenwen Wang wrote: > In divasmain.c, the function divas_write() firstly invokes the function >

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello Could you please review this patch? We need a confirmation because we are working on an approaching deadline. Thanks! Wenwen On Sat, May 5, 2018 at 2:32 PM, Wenwen Wang wrote: > In divasmain.c, the function divas_write() firstly invokes the function > diva_xdi_open_adapter() to open the

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello, I am just notice your subject line.There are missing something i think On Sat, May 05, 2018 at 02:32:46PM -0500, Wenwen Wang wrote: In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello, I am just notice your subject line.There are missing something i think On Sat, May 05, 2018 at 02:32:46PM -0500, Wenwen Wang wrote: In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number

[PATCH] isdn: eicon: fix a missing-check bug

In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions

[PATCH] isdn: eicon: fix a missing-check bug

In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions