Re: [PATCH] kbuild: add -Wvla flag unconditionally

2019-05-12 Thread Masahiro Yamada
On Fri, May 10, 2019 at 1:52 AM Nick Desaulniers wrote: > > > On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada > > wrote: > > > This flag is documented in the GCC 4.6 manual, and recognized by > > > Clang as well. Let's rip off the cc-option switch. > > Checked w/ godbolt w/ Clang 4 and GCC

Re: [PATCH] kbuild: add -Wvla flag unconditionally

2019-05-09 Thread Nick Desaulniers
> On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada > wrote: > > This flag is documented in the GCC 4.6 manual, and recognized by > > Clang as well. Let's rip off the cc-option switch. Checked w/ godbolt w/ Clang 4 and GCC 4.6.4. Tested-by: Nick Desaulniers -- Thanks, ~Nick Desaulniers

Re: [PATCH] kbuild: add -Wvla flag unconditionally

2019-05-09 Thread Kees Cook
On Wed, May 8, 2019 at 11:46 PM Masahiro Yamada wrote: > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > > Signed-off-by: Masahiro Yamada Acked-by: Kees Cook -- Kees Cook

Re: [PATCH] kbuild: add -Wvla flag unconditionally

2019-05-09 Thread Nathan Chancellor
On Thu, May 09, 2019 at 03:45:49PM +0900, Masahiro Yamada wrote: > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > Makefile | 2 +- > 1 file

Re: [PATCH] kbuild: add -Wvla flag unconditionally

2019-05-09 Thread Sedat Dilek
On Thu, May 9, 2019 at 8:46 AM Masahiro Yamada wrote: > > This flag is documented in the GCC 4.6 manual, and recognized by > Clang as well. Let's rip off the cc-option switch. > [ CC Kees who did the VLA removal/cleanup ] Looks good to me. Reviewed-by: Sedat Dilek > Signed-off-by: Masahiro

[PATCH] kbuild: add -Wvla flag unconditionally

2019-05-09 Thread Masahiro Yamada
This flag is documented in the GCC 4.6 manual, and recognized by Clang as well. Let's rip off the cc-option switch. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c71ffb6f55b5..3f5e8a0f4561 100644 ---