Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-18 Thread Josh Poimboeuf
On Wed, Mar 10, 2021 at 10:44:46PM +0900, Masahiro Yamada wrote: > > Masahiro, > > > > Ping. Do you have a better approach for building GCC plugins in the > > external module directory? > > > I am not sure if building GCC plugins in the external module directory > is the right approach. I'm cer

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-10 Thread Masahiro Yamada
On Wed, Mar 10, 2021 at 5:31 AM Josh Poimboeuf wrote: > > On Fri, Mar 05, 2021 at 08:50:59PM -0600, Josh Poimboeuf wrote: > > > Is this a bad coding contest? > > > > > > I am not asking you to add ugly ifeq or whatever > > > hacks to say "this worked for me". > > > > > > Please feel free to do thi

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-09 Thread Josh Poimboeuf
On Fri, Mar 05, 2021 at 08:50:59PM -0600, Josh Poimboeuf wrote: > > Is this a bad coding contest? > > > > I am not asking you to add ugly ifeq or whatever > > hacks to say "this worked for me". > > > > Please feel free to do this in the fedora kernel, > > but do not send it to upstream. > > > >

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-05 Thread Josh Poimboeuf
On Sat, Mar 06, 2021 at 11:18:31AM +0900, Masahiro Yamada wrote: > On Sat, Mar 6, 2021 at 10:28 AM Josh Poimboeuf wrote: > > > > On Thu, Mar 04, 2021 at 08:25:00PM -0600, Josh Poimboeuf wrote: > > > On Thu, Mar 04, 2021 at 03:37:14PM -0800, Linus Torvalds wrote: > > > > On Thu, Mar 4, 2021 at 3:20

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-05 Thread Masahiro Yamada
On Sat, Mar 6, 2021 at 10:28 AM Josh Poimboeuf wrote: > > On Thu, Mar 04, 2021 at 08:25:00PM -0600, Josh Poimboeuf wrote: > > On Thu, Mar 04, 2021 at 03:37:14PM -0800, Linus Torvalds wrote: > > > On Thu, Mar 4, 2021 at 3:20 PM Kees Cook wrote: > > > > > > > > This seems fine to me, but I want to

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-05 Thread Josh Poimboeuf
On Thu, Mar 04, 2021 at 08:25:00PM -0600, Josh Poimboeuf wrote: > On Thu, Mar 04, 2021 at 03:37:14PM -0800, Linus Torvalds wrote: > > On Thu, Mar 4, 2021 at 3:20 PM Kees Cook wrote: > > > > > > This seems fine to me, but I want to make sure Josh has somewhere to > > > actually go with this. Josh,

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-04 Thread Josh Poimboeuf
On Thu, Mar 04, 2021 at 03:37:14PM -0800, Linus Torvalds wrote: > On Thu, Mar 4, 2021 at 3:20 PM Kees Cook wrote: > > > > This seems fine to me, but I want to make sure Josh has somewhere to > > actually go with this. Josh, does this get you any closer? No, this doesn't seem to help me at all. >

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-04 Thread Linus Torvalds
On Thu, Mar 4, 2021 at 3:20 PM Kees Cook wrote: > > This seems fine to me, but I want to make sure Josh has somewhere to > actually go with this. Josh, does this get you any closer? It sounds > like the plugins need to move to another location for packaged kernels? Well, it might be worth extendi

Re: [PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-04 Thread Kees Cook
On Thu, Mar 04, 2021 at 08:37:08PM +0900, Masahiro Yamada wrote: > Linus reported a build error due to the GCC plugin incompatibility > when the compiler is upgraded. [1] > > cc1: error: incompatible gcc/plugin versions > cc1: error: failed to initialize plugin > ./scripts/gcc-plugins/stackle

[PATCH] kbuild: rebuild GCC plugins when the compiler is upgraded

2021-03-04 Thread Masahiro Yamada
Linus reported a build error due to the GCC plugin incompatibility when the compiler is upgraded. [1] cc1: error: incompatible gcc/plugin versions cc1: error: failed to initialize plugin ./scripts/gcc-plugins/stackleak_plugin.so GCC plugins are tied to a particular GCC version. So, they must