Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Chen Gang
于 2013年02月06日 23:24, Serge Hallyn 写道: > This really seems like splitting hairs to me. > > Acked-by: Serge E. Hallyn > > on the original patch. > > thanks, > -serge thank you. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Chen Gang
于 2013年02月07日 03:41, Kees Cook 写道: > Well, it seems we'd need to add an include to gain access to binfmts.h > in once place, but that doesn't seem bad. I'll send to patch to clean > this up. thank you. and after your patch is integrated into main branch (at least in next-* branch), I should

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Kees Cook
On Wed, Feb 6, 2013 at 2:36 AM, Chen Gang wrote: > 于 2013年02月06日 16:56, Cyrill Gorcunov 写道: >> On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: >>> > >>> > diff --git a/kernel/sys.c b/kernel/sys.c >>> > index 24d1ef5..568b9ca 100644 >>> > --- a/kernel/sys.c >>> > +++ b/kernel/sys.c >>>

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Cyrill Gorcunov
On Wed, Feb 06, 2013 at 06:36:38PM +0800, Chen Gang wrote: ... > > result: > still use the macros of branch 1 > and use branch 1 macros instead of branch 2 macros (need an additional > patch). Oh, what a mess ;) The reason I used SUID_DUMPABLE_DISABLED -- because it's used in set_dumpable

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Serge Hallyn
Quoting Chen Gang (gang.c...@asianux.com): > 于 2013年02月06日 16:56, Cyrill Gorcunov 写道: > > On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: > >> > > >> > diff --git a/kernel/sys.c b/kernel/sys.c > >> > index 24d1ef5..568b9ca 100644 > >> > --- a/kernel/sys.c > >> > +++ b/kernel/sys.c > >>

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Chen Gang
于 2013年02月06日 16:56, Cyrill Gorcunov 写道: > On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: >> > >> > diff --git a/kernel/sys.c b/kernel/sys.c >> > index 24d1ef5..568b9ca 100644 >> > --- a/kernel/sys.c >> > +++ b/kernel/sys.c >> > @@ -2027,7 +2027,7 @@ SYSCALL_DEFINE5(prctl, int,

Re: [PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Cyrill Gorcunov
On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: > > arg2 will never < 0, for its type is 'unsigned long' > > so delete the waste code. > > > Signed-off-by: Chen Gang > --- > kernel/sys.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

[PATCH] kernel: arg2 is unsigned long which is never < 0

2013-02-06 Thread Chen Gang
arg2 will never < 0, for its type is 'unsigned long' so delete the waste code. Signed-off-by: Chen Gang --- kernel/sys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index 24d1ef5..568b9ca 100644 --- a/kernel/sys.c +++

[PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Chen Gang
arg2 will never 0, for its type is 'unsigned long' so delete the waste code. Signed-off-by: Chen Gang gang.c...@asianux.com --- kernel/sys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index 24d1ef5..568b9ca 100644 ---

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Cyrill Gorcunov
On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: arg2 will never 0, for its type is 'unsigned long' so delete the waste code. Signed-off-by: Chen Gang gang.c...@asianux.com --- kernel/sys.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Chen Gang
于 2013年02月06日 16:56, Cyrill Gorcunov 写道: On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: diff --git a/kernel/sys.c b/kernel/sys.c index 24d1ef5..568b9ca 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2027,7 +2027,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long,

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Serge Hallyn
Quoting Chen Gang (gang.c...@asianux.com): 于 2013年02月06日 16:56, Cyrill Gorcunov 写道: On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: diff --git a/kernel/sys.c b/kernel/sys.c index 24d1ef5..568b9ca 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2027,7 +2027,7 @@

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Cyrill Gorcunov
On Wed, Feb 06, 2013 at 06:36:38PM +0800, Chen Gang wrote: ... result: still use the macros of branch 1 and use branch 1 macros instead of branch 2 macros (need an additional patch). Oh, what a mess ;) The reason I used SUID_DUMPABLE_DISABLED -- because it's used in set_dumpable which

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Kees Cook
On Wed, Feb 6, 2013 at 2:36 AM, Chen Gang gang.c...@asianux.com wrote: 于 2013年02月06日 16:56, Cyrill Gorcunov 写道: On Wed, Feb 06, 2013 at 04:44:35PM +0800, Chen Gang wrote: diff --git a/kernel/sys.c b/kernel/sys.c index 24d1ef5..568b9ca 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Chen Gang
于 2013年02月07日 03:41, Kees Cook 写道: Well, it seems we'd need to add an include to gain access to binfmts.h in once place, but that doesn't seem bad. I'll send to patch to clean this up. thank you. and after your patch is integrated into main branch (at least in next-* branch), I should

Re: [PATCH] kernel: arg2 is unsigned long which is never 0

2013-02-06 Thread Chen Gang
于 2013年02月06日 23:24, Serge Hallyn 写道: This really seems like splitting hairs to me. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com on the original patch. thanks, -serge thank you. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line unsubscribe