Re: [PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-10 Thread Chen Gang
On 2013年04月11日 01:31, Eric Paris wrote: > - Original Message - >> > >> > __audit_socketcall is an extern function. >> > better to check its parameters by itself. >> > >> > also can return error code, when fail (find invalid parameters). >> > also use macro instead of real

Re: [PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-10 Thread Eric Paris
- Original Message - > > __audit_socketcall is an extern function. > better to check its parameters by itself. > > also can return error code, when fail (find invalid parameters). > also use macro instead of real hard code number > also give related comments for it. > >

Re: [PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-10 Thread Eric Paris
- Original Message - __audit_socketcall is an extern function. better to check its parameters by itself. also can return error code, when fail (find invalid parameters). also use macro instead of real hard code number also give related comments for it.

Re: [PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-10 Thread Chen Gang
On 2013年04月11日 01:31, Eric Paris wrote: - Original Message - __audit_socketcall is an extern function. better to check its parameters by itself. also can return error code, when fail (find invalid parameters). also use macro instead of real hard code number

[PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-07 Thread Chen Gang
__audit_socketcall is an extern function. better to check its parameters by itself. also can return error code, when fail (find invalid parameters). also use macro instead of real hard code number also give related comments for it. Signed-off-by: Chen Gang ---

[PATCH] kernel: audit: beautify code, for extern function, better to check its parameters by itself

2013-04-07 Thread Chen Gang
__audit_socketcall is an extern function. better to check its parameters by itself. also can return error code, when fail (find invalid parameters). also use macro instead of real hard code number also give related comments for it. Signed-off-by: Chen Gang gang.c...@asianux.com