Hi Derek,
My comments on your code:
> +Changes:
> +v0.1 26 March 2005
> + Initial Release - developed on uClinux with 2.6.9 kernel
> +v0.2 11 April 2005
> + Coding style changes
> +
Changelogs are not welcome in kernel code.
> +#include
> +#include
Hi Derek,
My comments on your code:
+Changes:
+v0.1 26 March 2005
+ Initial Release - developed on uClinux with 2.6.9 kernel
+v0.2 11 April 2005
+ Coding style changes
+
Changelogs are not welcome in kernel code.
+#include linux/config.h
On Wed, Apr 13, 2005 at 09:12:53PM -0400, Derek Cheung wrote:
> OK, hope this patch can satisfy everyone :-)
>
> The following is the diffstat of the enclosed patch file:
>
> drivers/i2c/busses/Kconfig | 10
> drivers/i2c/busses/Makefile |1
> drivers/i2c/busses/i2c-mcf5282.c
On Wed, Apr 13, 2005 at 09:12:53PM -0400, Derek Cheung wrote:
OK, hope this patch can satisfy everyone :-)
The following is the diffstat of the enclosed patch file:
drivers/i2c/busses/Kconfig | 10
drivers/i2c/busses/Makefile |1
drivers/i2c/busses/i2c-mcf5282.c | 414
-
From: Greg KH [mailto:[EMAIL PROTECTED]
Sent: April 11, 2005 4:03 PM
To: Derek Cheung
Cc: 'Randy.Dunlap'; 'Andrew Morton'; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote
-
From: Greg KH [mailto:[EMAIL PROTECTED]
Sent: April 11, 2005 4:03 PM
To: Derek Cheung
Cc: 'Randy.Dunlap'; 'Andrew Morton'; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote:
> Enclosed please find the updated patch that incorporates changes for all
> the comments I received.
You did not cc: the sensors mailing list, nor fix all of the coding
style issues.
> The volatile declaration in the m528xsim.h is
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote:
Enclosed please find the updated patch that incorporates changes for all
the comments I received.
You did not cc: the sensors mailing list, nor fix all of the coding
style issues.
The volatile declaration in the m528xsim.h is
On Sun, 10 Apr 2005 12:47:42 -0400 Derek Cheung wrote:
| Enclosed please find the updated patch that incorporates changes for all
| the comments I received.
(yes, almost all)
| The volatile declaration in the m528xsim.h is needed because the
| declaration refers to the ColdFire 5282 register
"Derek Cheung" <[EMAIL PROTECTED]> wrote:
>
> Enclosed please find the updated patch that incorporates changes for all
> the comments I received.
>
> The volatile declaration in the m528xsim.h is needed because the
> declaration refers to the ColdFire 5282 register mapping. The volatile
>
'; [EMAIL PROTECTED]; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU
Derek Cheung wrote:
>
>> Below please find the patch file I "diff" against Linux 2.6.11.6. It
>> contains the I2C adaptor for ColdFire 5282 CPU.
'; [EMAIL PROTECTED]; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU
Derek Cheung wrote:
Below please find the patch file I diff against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire
CPU
shares
Derek Cheung [EMAIL PROTECTED] wrote:
Enclosed please find the updated patch that incorporates changes for all
the comments I received.
The volatile declaration in the m528xsim.h is needed because the
declaration refers to the ColdFire 5282 register mapping. The volatile
declaration is
On Sun, 10 Apr 2005 12:47:42 -0400 Derek Cheung wrote:
| Enclosed please find the updated patch that incorporates changes for all
| the comments I received.
(yes, almost all)
| The volatile declaration in the m528xsim.h is needed because the
| declaration refers to the ColdFire 5282 register
On Tue, Apr 05, 2005 at 08:10:27PM -0700, Randy.Dunlap wrote:
> There is a fairly up-to-date dontdiff file available at
> http://developer.osdl.org/rddunlap/doc/dontdiff-osdl
Can we stash a copy in Documentation?
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this
On Tue, Apr 05, 2005 at 08:10:27PM -0700, Randy.Dunlap wrote:
There is a fairly up-to-date dontdiff file available at
http://developer.osdl.org/rddunlap/doc/dontdiff-osdl
Can we stash a copy in Documentation?
--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this
On Tue, Apr 05, 2005 at 08:43:45PM -0700, Randy.Dunlap wrote:
> Big Question: does most Coldfire or I2C use volatile so heavily,
> or is it just this one driver that does that? Volatile here
> semms very overused.
It's not a i2c issue, volatile should not be needed here at all.
thanks,
greg
On Tue, Apr 05, 2005 at 08:43:45PM -0700, Randy.Dunlap wrote:
Big Question: does most Coldfire or I2C use volatile so heavily,
or is it just this one driver that does that? Volatile here
semms very overused.
It's not a i2c issue, volatile should not be needed here at all.
thanks,
greg k-h
Derek Cheung wrote:
Below please find the patch file I "diff" against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire
CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on a
On Tue, Apr 05, 2005 at 10:18:15PM -0400, Derek Cheung wrote:
> Hi Greg and Andrew,
After you fix the diff issues that Randy pointed out, please be sure to
CC: the sensors mailing list as found in the MAINTAINERS file. I know
they will be able to give you feedback on the code.
thanks,
greg
Derek Cheung wrote:
Below please find the patch file I "diff" against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire
CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on a
Thanks Andrew. Enclosed please find the patch file.
Regards,
Derek
-Original Message-
From: Andrew Morton [mailto:[EMAIL PROTECTED]
Sent: April 5, 2005 10:22 PM
To: Derek Cheung
Cc: [EMAIL PROTECTED]; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor
"Derek Cheung" <[EMAIL PROTECTED]> wrote:
>
> Below please find the patch file I "diff" against Linux 2.6.11.6. It
> contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire CPU
> shares the same I2C register set, the code can be easily adopted for
> other ColdFire CPUs for I2C
Hi Greg and Andrew,
Below please find the patch file I "diff" against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on
Hi Greg and Andrew,
Below please find the patch file I diff against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on a
Derek Cheung [EMAIL PROTECTED] wrote:
Below please find the patch file I diff against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
Thanks Andrew. Enclosed please find the patch file.
Regards,
Derek
-Original Message-
From: Andrew Morton [mailto:[EMAIL PROTECTED]
Sent: April 5, 2005 10:22 PM
To: Derek Cheung
Cc: [EMAIL PROTECTED]; Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 - I2C adaptor
Derek Cheung wrote:
Below please find the patch file I diff against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire
CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on a
On Tue, Apr 05, 2005 at 10:18:15PM -0400, Derek Cheung wrote:
Hi Greg and Andrew,
After you fix the diff issues that Randy pointed out, please be sure to
CC: the sensors mailing list as found in the MAINTAINERS file. I know
they will be able to give you feedback on the code.
thanks,
greg k-h
Derek Cheung wrote:
Below please find the patch file I diff against Linux 2.6.11.6. It
contains the I2C adaptor for ColdFire 5282 CPU. Since most ColdFire
CPU
shares the same I2C register set, the code can be easily adopted for
other ColdFire CPUs for I2C operations.
I have tested the code on a
30 matches
Mail list logo
