Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 03:59:06PM +0300, Konstantin Khlebnikov wrote: > > > On 08.02.2017 15:51, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: > > > Null kernfs nodes could be found at cgroups during construction. > > > > Really? Does

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 03:59:06PM +0300, Konstantin Khlebnikov wrote: > > > On 08.02.2017 15:51, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: > > > Null kernfs nodes could be found at cgroups during construction. > > > > Really? Does

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
On 08.02.2017 16:23, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 03:59:06PM +0300, Konstantin Khlebnikov wrote: On 08.02.2017 15:51, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: Null kernfs nodes could be found at cgroups during

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
On 08.02.2017 16:23, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 03:59:06PM +0300, Konstantin Khlebnikov wrote: On 08.02.2017 15:51, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: Null kernfs nodes could be found at cgroups during

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
On 08.02.2017 15:51, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: Null kernfs nodes could be found at cgroups during construction. Really? Does this happen today? Is this an issue for older kernels as well? This happended again

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
On 08.02.2017 15:51, Greg Kroah-Hartman wrote: On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: Null kernfs nodes could be found at cgroups during construction. Really? Does this happen today? Is this an issue for older kernels as well? This happended again

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: > Null kernfs nodes could be found at cgroups during construction. Really? Does this happen today? Is this an issue for older kernels as well? > It seems safer to handle these null pointers right in kernfs in > the same way

Re: [PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 02:28:55PM +0300, Konstantin Khlebnikov wrote: > Null kernfs nodes could be found at cgroups during construction. Really? Does this happen today? Is this an issue for older kernels as well? > It seems safer to handle these null pointers right in kernfs in > the same way

[PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
Null kernfs nodes could be found at cgroups during construction. It seems safer to handle these null pointers right in kernfs in the same way as printf prints "(null)" for null pointer string. Signed-off-by: Konstantin Khlebnikov Acked-by: Tejun Heo

[PATCH] kernfs: handle null pointers while printing node name and path

2017-02-08 Thread Konstantin Khlebnikov
Null kernfs nodes could be found at cgroups during construction. It seems safer to handle these null pointers right in kernfs in the same way as printf prints "(null)" for null pointer string. Signed-off-by: Konstantin Khlebnikov Acked-by: Tejun Heo --- fs/kernfs/dir.c | 10