Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2019-01-10 Thread Will Deacon
On Thu, Jan 03, 2019 at 07:43:10AM +, xiaoguangrong(Xiao Guangrong) wrote: > On 12/12/18 8:50 AM, Kees Cook wrote: > > On Mon, Dec 10, 2018 at 7:41 PM wrote: > >> > >> From: Yulei Zhang > >> > >> Early this year we spot there may be two issues in kernel > >> kfifo. > >> > >> One is reported

Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2019-01-02 Thread xiaoguangrong(Xiao Guangrong)
On 12/12/18 8:50 AM, Kees Cook wrote: > On Mon, Dec 10, 2018 at 7:41 PM wrote: >> >> From: Yulei Zhang >> >> Early this year we spot there may be two issues in kernel >> kfifo. >> >> One is reported by Xiao Guangrong to linux kernel. >> https://lkml.org/lkml/2018/5/11/58 >> In current kfifo

Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2018-12-16 Thread kbuild test robot
Hi Yulei, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.20-rc6 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2018-12-14 Thread Will Deacon
On Tue, Dec 11, 2018 at 04:50:34PM -0800, Kees Cook wrote: > On Mon, Dec 10, 2018 at 7:41 PM wrote: > > > > From: Yulei Zhang > > > > Early this year we spot there may be two issues in kernel > > kfifo. > > > > One is reported by Xiao Guangrong to linux kernel. > >

Re: [PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2018-12-11 Thread Kees Cook
On Mon, Dec 10, 2018 at 7:41 PM wrote: > > From: Yulei Zhang > > Early this year we spot there may be two issues in kernel > kfifo. > > One is reported by Xiao Guangrong to linux kernel. > https://lkml.org/lkml/2018/5/11/58 > In current kfifo implementation there are missing memory > barrier in

[PATCH] kfifo: add memory barrier in kfifo to prevent data loss

2018-12-10 Thread yulei . kernel
From: Yulei Zhang Early this year we spot there may be two issues in kernel kfifo. One is reported by Xiao Guangrong to linux kernel. https://lkml.org/lkml/2018/5/11/58 In current kfifo implementation there are missing memory barrier in the read side, so that without proper barrier between