Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-08 Thread Ingo Molnar
* Michal Schmidt <[EMAIL PROTECTED]> wrote: > Allow the administrator to change kthreadd's priority and affinity. > Ensure that the kernel threads are created with the usual nice level > and affinity even if kthreadd's properties were changed from the > default. > > Signed-off-by: Michal

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-08 Thread Michal Schmidt
On Mon, 7 Jan 2008 09:29:56 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > > > This causes a practical problem. When a runaway real-time task > > > > is eating 100% CPU and we attempt to put the CPU offline, >

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-08 Thread Michal Schmidt
On Mon, 7 Jan 2008 09:29:56 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: This causes a practical problem. When a runaway real-time task is eating 100% CPU and we attempt to put the CPU offline, sometimes we

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-08 Thread Ingo Molnar
* Michal Schmidt [EMAIL PROTECTED] wrote: Allow the administrator to change kthreadd's priority and affinity. Ensure that the kernel threads are created with the usual nice level and affinity even if kthreadd's properties were changed from the default. Signed-off-by: Michal Schmidt

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Peter Zijlstra
On Mon, 2008-01-07 at 09:29 -0800, Andrew Morton wrote: > On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > > > This causes a practical problem. When a runaway real-time task is > > > > eating 100% CPU and we attempt to put the CPU offline, sometimes we > > >

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > This causes a practical problem. When a runaway real-time task is > > > eating 100% CPU and we attempt to put the CPU offline, sometimes we > > > block while waiting for the creation of the highest-priority > > >

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Remy Bohmer
Hello Michal, > > Maybe we can find a way to use a similar mechanism as I used in my > > patchset for the priorities of the remaining kthreads. > > I do not like the way of forcing userland to change the priorities, > > because that would require a userland with the chrt tool installed, > > and

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Michal Schmidt
On Mon, 7 Jan 2008 02:25:13 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 7 Jan 2008 11:06:03 +0100 Michal Schmidt > <[EMAIL PROTECTED]> wrote: > > > On Sat, 22 Dec 2007 01:30:21 -0800 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > On Mon, 17 Dec 2007 23:43:14 +0100 Michal

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Michal Schmidt
On Mon, 7 Jan 2008 12:22:51 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Michal and Andrew, > > > Let's not make the decision for the user. Just allow the > > administrator to change kthreadd's priority safely if he chooses to > > do it. Ensure that the kernel threads are created with

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Remy Bohmer
Hello Michal and Andrew, > Let's not make the decision for the user. Just allow the administrator to > change kthreadd's priority safely if he chooses to do it. Ensure that the > kernel threads are created with the usual nice level even if kthreadd's > priority is changed from the default. Last

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Ingo Molnar
> > This causes a practical problem. When a runaway real-time task is > > eating 100% CPU and we attempt to put the CPU offline, sometimes we > > block while waiting for the creation of the highest-priority > > "kstopmachine" thread. sched-devel.git has new mechanisms against runaway RT

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 11:06:03 +0100 Michal Schmidt <[EMAIL PROTECTED]> wrote: > On Sat, 22 Dec 2007 01:30:21 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Mon, 17 Dec 2007 23:43:14 +0100 Michal Schmidt > > <[EMAIL PROTECTED]> wrote: > > > > > kthreadd, the creator of other kernel

[PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Michal Schmidt
On Sat, 22 Dec 2007 01:30:21 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 17 Dec 2007 23:43:14 +0100 Michal Schmidt > <[EMAIL PROTECTED]> wrote: > > > kthreadd, the creator of other kernel threads, runs as a normal > > priority task. This is a potential for priority inversion when a

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Ingo Molnar
This causes a practical problem. When a runaway real-time task is eating 100% CPU and we attempt to put the CPU offline, sometimes we block while waiting for the creation of the highest-priority kstopmachine thread. sched-devel.git has new mechanisms against runaway RT tasks. There's

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Remy Bohmer
Hello Michal and Andrew, Let's not make the decision for the user. Just allow the administrator to change kthreadd's priority safely if he chooses to do it. Ensure that the kernel threads are created with the usual nice level even if kthreadd's priority is changed from the default. Last

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Michal Schmidt
On Mon, 7 Jan 2008 12:22:51 +0100 Remy Bohmer [EMAIL PROTECTED] wrote: Hello Michal and Andrew, Let's not make the decision for the user. Just allow the administrator to change kthreadd's priority safely if he chooses to do it. Ensure that the kernel threads are created with the usual

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Michal Schmidt
On Mon, 7 Jan 2008 02:25:13 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 7 Jan 2008 11:06:03 +0100 Michal Schmidt [EMAIL PROTECTED] wrote: On Sat, 22 Dec 2007 01:30:21 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 23:43:14 +0100 Michal Schmidt [EMAIL

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Remy Bohmer
Hello Michal, Maybe we can find a way to use a similar mechanism as I used in my patchset for the priorities of the remaining kthreads. I do not like the way of forcing userland to change the priorities, because that would require a userland with the chrt tool installed, and that is not

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: This causes a practical problem. When a runaway real-time task is eating 100% CPU and we attempt to put the CPU offline, sometimes we block while waiting for the creation of the highest-priority kstopmachine

Re: [PATCH] kthread: always create the kernel threads with normal priority

2008-01-07 Thread Peter Zijlstra
On Mon, 2008-01-07 at 09:29 -0800, Andrew Morton wrote: On Mon, 7 Jan 2008 12:09:04 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: This causes a practical problem. When a runaway real-time task is eating 100% CPU and we attempt to put the CPU offline, sometimes we block while