Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Greg Kroah-Hartman
On Fri, Sep 13, 2019 at 09:34:49AM +0900, Akinobu Mita wrote: > 2019年9月13日(金) 2:15 Jacek Anaszewski : > > > > Hi Akinobu, > > > > Please bump patch version each time you send an update > > of the patch with the same subject. > > Oops, should I resend with the correct subject? Yes please.

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Akinobu Mita
2019年9月13日(金) 2:15 Jacek Anaszewski : > > Hi Akinobu, > > Please bump patch version each time you send an update > of the patch with the same subject. Oops, should I resend with the correct subject?

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Jacek Anaszewski
Hi Akinobu, Please bump patch version each time you send an update of the patch with the same subject. Best regards, Jacek Anaszewski On 9/12/19 4:39 PM, Akinobu Mita wrote: > Reading /sys/class/leds//trigger returns all available LED triggers. > However, the size of this file is limited to

[PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute. Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Pavel Machek
Hi! > > Also, you all didn't document the heck out of this. So no, I really do > > not want to see this patch accepted as-is. > > > > > Provided that will be fixed, can we count on your ack for the > > > implementation of the solution you proposed? :-) > > > > Let's see the patch that actually

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 08:18:36PM +0200, Jacek Anaszewski wrote: > On 9/3/19 4:21 PM, Akinobu Mita wrote: > > 2019年9月3日(火) 23:07 Greg KH : > >> > >> On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > >>> 2019年9月3日(火) 4:08 Greg KH : > > On Mon, Sep 02, 2019 at 08:47:02PM

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Jacek Anaszewski
On 9/3/19 4:21 PM, Akinobu Mita wrote: > 2019年9月3日(火) 23:07 Greg KH : >> >> On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: >>> 2019年9月3日(火) 4:08 Greg KH : On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > On 9/2/19 8:12 PM, Greg KH wrote: >> On

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 11:21:59PM +0900, Akinobu Mita wrote: > 2019年9月3日(火) 23:07 Greg KH : > > > > On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > > > 2019年9月3日(火) 4:08 Greg KH : > > > > > > > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > > > > > On 9/2/19

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Akinobu Mita
2019年9月3日(火) 23:07 Greg KH : > > On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > > 2019年9月3日(火) 4:08 Greg KH : > > > > > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > > > > On 9/2/19 8:12 PM, Greg KH wrote: > > > > > On Sun, Sep 01, 2019 at 06:53:34PM +0200,

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > 2019年9月3日(火) 4:08 Greg KH : > > > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > > > On 9/2/19 8:12 PM, Greg KH wrote: > > > > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: > > > >> Hi

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-03 Thread Akinobu Mita
2019年9月3日(火) 4:08 Greg KH : > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > > On 9/2/19 8:12 PM, Greg KH wrote: > > > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: > > >> Hi Akinobu, > > >> > > >> Thank you for the patch. > > >> > > >> I have one nit

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-02 Thread Greg KH
On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > On 9/2/19 8:12 PM, Greg KH wrote: > > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: > >> Hi Akinobu, > >> > >> Thank you for the patch. > >> > >> I have one nit below but in general it looks good to me. > >>

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-02 Thread Jacek Anaszewski
On 9/2/19 8:12 PM, Greg KH wrote: > On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: >> Hi Akinobu, >> >> Thank you for the patch. >> >> I have one nit below but in general it looks good to me. >> I've tested it with 2000 mtd triggers (~14kB file size) >> and it worked flawlessly.

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-02 Thread Greg KH
On Sun, Sep 01, 2019 at 06:53:34PM +0200, Jacek Anaszewski wrote: > Hi Akinobu, > > Thank you for the patch. > > I have one nit below but in general it looks good to me. > I've tested it with 2000 mtd triggers (~14kB file size) > and it worked flawlessly. > > Still, I would like to have ack

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-01 Thread Pavel Machek
Hi! > Reading /sys/class/leds//trigger returns all available LED triggers. > However, the size of this file is limited to PAGE_SIZE because of the > limitation for sysfs attribute. > > Enabling LED CPU trigger on systems with thousands of CPUs easily hits > PAGE_SIZE limit, and makes it

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-01 Thread Jacek Anaszewski
Hi Akinobu, Thank you for the patch. I have one nit below but in general it looks good to me. I've tested it with 2000 mtd triggers (~14kB file size) and it worked flawlessly. Still, I would like to have ack from Greg for it. Adding Greg on Cc. On 8/29/19 4:49 PM, Akinobu Mita wrote: >

[PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-08-29 Thread Akinobu Mita
Reading /sys/class/leds//trigger returns all available LED triggers. However, the size of this file is limited to PAGE_SIZE because of the limitation for sysfs attribute. Enabling LED CPU trigger on systems with thousands of CPUs easily hits PAGE_SIZE limit, and makes it impossible to see all