Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-13 Thread Tejun Heo
On Thu, Dec 12, 2013 at 09:36:55PM +0100, Levente Kurusa wrote: > >1. > >Countering your nodisable comment, would it be valid to do: > >libata.force=2:disable libata.force=2.02:nodisable > >To disable all of port 2 except device 2? > > I think that makes sense and I support having 'nodisable'. I

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-13 Thread Tejun Heo
On Thu, Dec 12, 2013 at 09:36:55PM +0100, Levente Kurusa wrote: 1. Countering your nodisable comment, would it be valid to do: libata.force=2:disable libata.force=2.02:nodisable To disable all of port 2 except device 2? I think that makes sense and I support having 'nodisable'. I really

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
On Thu, Dec 12, 2013 at 09:36:55PM +0100, Levente Kurusa wrote: > > 2. One of my friends wondered if it would be worthwhile to add force > > keywords for other HORKAGE bits, and if so, should the > > ata_lflag/ata_link force bits also be presented? > I don't think so. Most of the other HORKAGEs

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Levente Kurusa
Hi, Robin. 2013-12-12 21:22, Robin H. Johnson: On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote: Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: + { "disable", .horkage_on = ATA_HORKAGE_DISABLE }, + { "nodisable",

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote: > Hello, Robin. > > On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: > > + { "disable",.horkage_on = ATA_HORKAGE_DISABLE }, > > + { "nodisable", .horkage_off= ATA_HORKAGE_DISABLE }, >

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Tejun Heo
Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: > + { "disable",.horkage_on = ATA_HORKAGE_DISABLE }, > + { "nodisable", .horkage_off= ATA_HORKAGE_DISABLE }, Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need

[PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
This was posted by a user on StackExchange, who has a failing SSD that's soldered directly onto the motherboard of his system. The BIOS does not give any option to disable it at all, so he can't just hide it that way. The old IDE layer had hdX=noprobe override for situations like this, but that

[PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
This was posted by a user on StackExchange, who has a failing SSD that's soldered directly onto the motherboard of his system. The BIOS does not give any option to disable it at all, so he can't just hide it that way. The old IDE layer had hdX=noprobe override for situations like this, but that

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Tejun Heo
Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: + { disable,.horkage_on = ATA_HORKAGE_DISABLE }, + { nodisable, .horkage_off= ATA_HORKAGE_DISABLE }, Given the current usage of ATA_HORKAGE_DISABLE, I don't think we need

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote: Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: + { disable,.horkage_on = ATA_HORKAGE_DISABLE }, + { nodisable, .horkage_off= ATA_HORKAGE_DISABLE }, Given the

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Levente Kurusa
Hi, Robin. 2013-12-12 21:22, Robin H. Johnson: On Thu, Dec 12, 2013 at 08:39:35AM -0500, Tejun Heo wrote: Hello, Robin. On Sat, Dec 07, 2013 at 04:56:27PM -0800, Robin H. Johnson wrote: + { disable, .horkage_on = ATA_HORKAGE_DISABLE }, + { nodisable,

Re: [PATCH] libata: provide the ability to disable a disk via the params.

2013-12-12 Thread Robin H. Johnson
On Thu, Dec 12, 2013 at 09:36:55PM +0100, Levente Kurusa wrote: 2. One of my friends wondered if it would be worthwhile to add force keywords for other HORKAGE bits, and if so, should the ata_lflag/ata_link force bits also be presented? I don't think so. Most of the other HORKAGEs are