Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-05 Thread Bill Davidsen
Stephen Clark wrote: Bill Davidsen wrote: Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-05 Thread Bill Davidsen
Stephen Clark wrote: Bill Davidsen wrote: Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Stephen Clark
Bill Davidsen wrote: Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Bill Davidsen
Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Stephen Clark
Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Stephen Clark
Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Bill Davidsen
Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-04 Thread Stephen Clark
Bill Davidsen wrote: Stephen Clark wrote: Bill Davidsen wrote: Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-03 Thread Bill Davidsen
Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-03 Thread Bill Davidsen
Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very last

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Jeff Garzik
Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's ->mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Alan Cox
> it seems broken to manipulate xfer_mask after returning from the > driver's ->mode_filter hook. > > this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very last test

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Jeff Garzik
Robert Hancock wrote: Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Jeff Garzik
Robert Hancock wrote: Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Alan Cox
it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very last test made.

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-03-02 Thread Jeff Garzik
Alan Cox wrote: it seems broken to manipulate xfer_mask after returning from the driver's -mode_filter hook. this patch is more than just a speed-limited warning printk, afaics I actually suggested that order because the only way the printk can be done correctly is for it to be the very last

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-20 Thread Alan
> cleaned up somewhat. Also, it's been inadvertently tested (it seems that > pata_amd Nvidia cable detection is broken in current -git..) Yes. The pata_acpi driver fixes that one, but got kicked out as it didn't match other merges at the same time. It'll be back soon > > Signed-off-by: Robert

Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-20 Thread Alan
cleaned up somewhat. Also, it's been inadvertently tested (it seems that pata_amd Nvidia cable detection is broken in current -git..) Yes. The pata_acpi driver fixes that one, but got kicked out as it didn't match other merges at the same time. It'll be back soon Signed-off-by: Robert

[PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-19 Thread Robert Hancock
Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has been cleaned up

[PATCH] libata: warn if speed limited due to 40-wire cable (v2)

2007-02-19 Thread Robert Hancock
Here's a revised version of my previous patch to warn the user if a drive's transfer rate is limited because of a 40-wire cable detection. This one hopefully addresses Alan's previous comments - we now do this at the very end of the function, and the ugly if condition has been cleaned up