Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-13 Thread Sam Ravnborg
On Tue, Oct 09, 2012 at 01:36:28PM -0700, Josh Triplett wrote: > On Tue, Oct 09, 2012 at 01:06:37PM -0700, Andrew Morton wrote: > > On Sun, 7 Oct 2012 19:06:10 -0700 > > Josh Triplett wrote: > > > > > linux/compiler.h has macros to denote functions that acquire or release > > > locks, but not to

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-13 Thread Sam Ravnborg
On Tue, Oct 09, 2012 at 01:36:28PM -0700, Josh Triplett wrote: On Tue, Oct 09, 2012 at 01:06:37PM -0700, Andrew Morton wrote: On Sun, 7 Oct 2012 19:06:10 -0700 Josh Triplett j...@joshtriplett.org wrote: linux/compiler.h has macros to denote functions that acquire or release locks,

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Josh Triplett
On Tue, Oct 09, 2012 at 01:06:37PM -0700, Andrew Morton wrote: > On Sun, 7 Oct 2012 19:06:10 -0700 > Josh Triplett wrote: > > > linux/compiler.h has macros to denote functions that acquire or release > > locks, but not to denote functions called with a lock held that return > > with the lock

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Ed Cashin
On Oct 9, 2012, at 4:06 PM, Andrew Morton wrote: > On Sun, 7 Oct 2012 19:06:10 -0700 > Josh Triplett wrote: > >> linux/compiler.h has macros to denote functions that acquire or release >> locks, but not to denote functions called with a lock held that return >> with the lock still held. Add a

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Andrew Morton
On Sun, 7 Oct 2012 19:06:10 -0700 Josh Triplett wrote: > linux/compiler.h has macros to denote functions that acquire or release > locks, but not to denote functions called with a lock held that return > with the lock still held. Add a __must_hold macro to cover that case. hum. How does this

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Andrew Morton
On Sun, 7 Oct 2012 19:06:10 -0700 Josh Triplett j...@joshtriplett.org wrote: linux/compiler.h has macros to denote functions that acquire or release locks, but not to denote functions called with a lock held that return with the lock still held. Add a __must_hold macro to cover that case.

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Ed Cashin
On Oct 9, 2012, at 4:06 PM, Andrew Morton wrote: On Sun, 7 Oct 2012 19:06:10 -0700 Josh Triplett j...@joshtriplett.org wrote: linux/compiler.h has macros to denote functions that acquire or release locks, but not to denote functions called with a lock held that return with the lock still

Re: [PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-09 Thread Josh Triplett
On Tue, Oct 09, 2012 at 01:06:37PM -0700, Andrew Morton wrote: On Sun, 7 Oct 2012 19:06:10 -0700 Josh Triplett j...@joshtriplett.org wrote: linux/compiler.h has macros to denote functions that acquire or release locks, but not to denote functions called with a lock held that return with

[PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-07 Thread Josh Triplett
linux/compiler.h has macros to denote functions that acquire or release locks, but not to denote functions called with a lock held that return with the lock still held. Add a __must_hold macro to cover that case. Signed-off-by: Josh Triplett Reported-by: Ed Cashin Tested-by: Ed Cashin ---

[PATCH] linux/compiler.h: Add __must_hold macro for functions called with a lock held

2012-10-07 Thread Josh Triplett
linux/compiler.h has macros to denote functions that acquire or release locks, but not to denote functions called with a lock held that return with the lock still held. Add a __must_hold macro to cover that case. Signed-off-by: Josh Triplett j...@joshtriplett.org Reported-by: Ed Cashin