Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-18 Thread Robert P. J. Day
On Mon, 18 Feb 2008, [EMAIL PROTECTED] wrote: > On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said: > > > if that header file isn't used by any kernel code, why bother having a > > check for __KERNEL__ in the first place? it's being exported to > > userspace unchecked: > > > >

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-18 Thread Robert P. J. Day
On Mon, 18 Feb 2008, [EMAIL PROTECTED] wrote: On Sun, 17 Feb 2008 12:17:20 EST, Robert P. J. Day said: if that header file isn't used by any kernel code, why bother having a check for __KERNEL__ in the first place? it's being exported to userspace unchecked:

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Valdis . Kletnieks
On Sun, 17 Feb 2008 12:17:20 EST, "Robert P. J. Day" said: > if that header file isn't used by any kernel code, why bother having a > check for __KERNEL__ in the first place? it's being exported to > userspace unchecked: > > include/linux/Kbuild:header-y += hdsmart.h > > so why not just toss

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > On Sunday 17 February 2008, Adrian Bunk wrote: > > On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > On Sunday 17 February 2008, Robert P. J. Day wrote: > > > > On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Sunday 17 February 2008, Adrian Bunk wrote: > On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Sunday 17 February 2008, Robert P. J. Day wrote: > > > On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > > > > > > > Fix goofups of commit

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Adrian Bunk
On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sunday 17 February 2008, Robert P. J. Day wrote: > > On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > > > > > Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c > > > (" is not used by kernel

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
hy bother having a > check for __KERNEL__ in the first place? it's being exported to > userspace unchecked: > > include/linux/Kbuild:header-y += hdsmart.h > > so why not just toss that check entirely? otherwise, you're going to > get a header file exported to userspace tha

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c > (" is not used by kernel code"). > > Reported-by: "Robert P. J. Day" <[EMAIL PROTECTED]> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > --- >

[PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c (" is not used by kernel code"). Reported-by: "Robert P. J. Day" <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- include/linux/hdsmart.h |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c (linux/hdsmart.h is not used by kernel code). Reported-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/hdsmart.h |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c (linux/hdsmart.h is not used by kernel code). Reported-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
a superfluous __KERNEL__ test in it. We don't want new (accidental etc.) kernel users of this header. How's about this version? From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] linux/hdsmart.h: fix goofups (take 2) Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Adrian Bunk
On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 17 February 2008, Robert P. J. Day wrote: On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: Fix goofups of commit 76166952bbc81dda1c8a8c14e75a2aa06f6c052c (linux/hdsmart.h is not used by kernel

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Sunday 17 February 2008, Adrian Bunk wrote: On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 17 February 2008, Robert P. J. Day wrote: On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: Fix goofups of commit

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 17 February 2008, Adrian Bunk wrote: On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 17 February 2008, Robert P. J. Day wrote: On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote:

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Valdis . Kletnieks
On Sun, 17 Feb 2008 12:17:20 EST, Robert P. J. Day said: if that header file isn't used by any kernel code, why bother having a check for __KERNEL__ in the first place? it's being exported to userspace unchecked: include/linux/Kbuild:header-y += hdsmart.h so why not just toss that