Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-14 Thread Paul E. McKenney
On Fri, Sep 14, 2007 at 11:14:58PM +0200, Johannes Berg wrote: > On Mon, 2007-09-10 at 10:39 -0700, Paul E. McKenney wrote: > > On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: > > > To implement the multicast list callback in mac80211 we need to > > > do partial list iteration.

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-14 Thread Johannes Berg
On Mon, 2007-09-10 at 10:39 -0700, Paul E. McKenney wrote: > On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: > > To implement the multicast list callback in mac80211 we need to > > do partial list iteration. Since I want to convert the interface > > list to an RCU list, I need a new

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-14 Thread Johannes Berg
On Mon, 2007-09-10 at 10:39 -0700, Paul E. McKenney wrote: On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-14 Thread Paul E. McKenney
On Fri, Sep 14, 2007 at 11:14:58PM +0200, Johannes Berg wrote: On Mon, 2007-09-10 at 10:39 -0700, Paul E. McKenney wrote: On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-10 Thread Paul E. McKenney
On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: > To implement the multicast list callback in mac80211 we need to > do partial list iteration. Since I want to convert the interface > list to an RCU list, I need a new list walking primitive: > list_for_each_entry_continue_rcu(). > >

[PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-10 Thread Johannes Berg
To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu(). Additional help text was provided by Paul McKenney. Signed-off-by:

[PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-10 Thread Johannes Berg
To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu(). Additional help text was provided by Paul McKenney. Signed-off-by:

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-10 Thread Paul E. McKenney
On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote: To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu().

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
On Fri, 2007-09-07 at 12:57 -0700, Paul E. McKenney wrote: > Actually, list_for_each_continue_rcu() needs to be removed in favor of > your new list_for_each_entry_continue_rcu(). There are currently only > two users as of 2.6.22. One of them immediately does a list_entry(), > and the other

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Paul E. McKenney
On Fri, Sep 07, 2007 at 09:09:52PM +0200, Johannes Berg wrote: > On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote: > > > > + * Continue to iterate over rcu list of given type, continuing after > > > + * the current position. > > > > Please add something like the following to this

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote: > > + * Continue to iterate over rcu list of given type, continuing after > > + * the current position. > > Please add something like the following to this comment: > > Note that the caller is responsible for making sure that >

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Paul E. McKenney
On Fri, Sep 07, 2007 at 04:34:48PM +0200, Johannes Berg wrote: > To implement the multicast list callback in mac80211 we need to > do partial list iteration. Since I want to convert the interface > list to an RCU list, I need a new list walking primitive: > list_for_each_entry_continue_rcu(). > >

[PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu(). Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> Cc:

[PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu(). Signed-off-by: Johannes Berg [EMAIL PROTECTED] Cc:

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Paul E. McKenney
On Fri, Sep 07, 2007 at 04:34:48PM +0200, Johannes Berg wrote: To implement the multicast list callback in mac80211 we need to do partial list iteration. Since I want to convert the interface list to an RCU list, I need a new list walking primitive: list_for_each_entry_continue_rcu().

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote: + * Continue to iterate over rcu list of given type, continuing after + * the current position. Please add something like the following to this comment: Note that the caller is responsible for making sure that the

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Paul E. McKenney
On Fri, Sep 07, 2007 at 09:09:52PM +0200, Johannes Berg wrote: On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote: + * Continue to iterate over rcu list of given type, continuing after + * the current position. Please add something like the following to this comment:

Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

2007-09-07 Thread Johannes Berg
On Fri, 2007-09-07 at 12:57 -0700, Paul E. McKenney wrote: Actually, list_for_each_continue_rcu() needs to be removed in favor of your new list_for_each_entry_continue_rcu(). There are currently only two users as of 2.6.22. One of them immediately does a list_entry(), and the other would