Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Julia Lawall
On Mon, 3 Dec 2018, Peter Zijlstra wrote: > On Mon, Dec 03, 2018 at 10:20:42AM +0100, Julia Lawall wrote: > > Personally, I would prefer that assignments involving boolean variables > > use true or false. It seems more readable. Potentially better for tools > > as well. > > Then those tools

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Peter Zijlstra
On Mon, Dec 03, 2018 at 10:20:42AM +0100, Julia Lawall wrote: > Personally, I would prefer that assignments involving boolean variables > use true or false. It seems more readable. Potentially better for tools > as well. Then those tools are broken per the C spec. > But if the community really

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Julia Lawall
On Mon, 3 Dec 2018, Peter Zijlstra wrote: > On Mon, Dec 03, 2018 at 09:35:00AM +0100, Peter Zijlstra wrote: > > On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > > > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > > > Fix the following warnings reported by

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > > Fix the following warnings reported by coccinelle: > > > > > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Peter Zijlstra
On Mon, Dec 03, 2018 at 09:35:00AM +0100, Peter Zijlstra wrote: > On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > > Fix the following warnings reported by coccinelle: > > > > > >

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-03 Thread Peter Zijlstra
On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote: > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > > Fix the following warnings reported by coccinelle: > > > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1 > >

Re: [PATCH] locktorture: Fix assignment of boolean variables

2018-12-01 Thread Paul E. McKenney
On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote: > Fix the following warnings reported by coccinelle: > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1 > kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1 >

[PATCH] locktorture: Fix assignment of boolean variables

2018-12-01 Thread Wen Yang
Fix the following warnings reported by coccinelle: kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1 kernel/locking/locktorture.c:918:2-20: WARNING: Assignment of bool to 0/1 kernel/locking/locktorture.c:949:3-20: WARNING: Assignment of bool to 0/1