Re: [PATCH] lustre: obdclass: fix sparse warning
On Sun, Nov 01, 2015 at 02:12:29PM +0530, Paul Davies C wrote: > Fix the following warning given by sparse: > > drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol > 'cl_lock_mutex_try' was not declared. Should it be static? > > Signed-off-by: Paul Davies C > --- > drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c > b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > index 5621beb..6f83452 100644 > --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c > +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get); > * > * \see cl_lock_mutex_get() > */ > -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > { > int result; > Someone did this before you did, sorry :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] lustre: obdclass: fix sparse warning
On Sun, Nov 01, 2015 at 02:12:29PM +0530, Paul Davies C wrote: > Fix the following warning given by sparse: > > drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol > 'cl_lock_mutex_try' was not declared. Should it be static? > > Signed-off-by: Paul Davies C> --- > drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c > b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > index 5621beb..6f83452 100644 > --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c > +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c > @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get); > * > * \see cl_lock_mutex_get() > */ > -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) > { > int result; > Someone did this before you did, sorry :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lustre: obdclass: fix sparse warning
Fix the following warning given by sparse: drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static? Signed-off-by: Paul Davies C --- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c index 5621beb..6f83452 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get); * * \see cl_lock_mutex_get() */ -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) { int result; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lustre: obdclass: fix sparse warning
Fix the following warning given by sparse: drivers/staging/lustre/lustre/obdclass/cl_lock.c:690:5: warning: symbol 'cl_lock_mutex_try' was not declared. Should it be static? Signed-off-by: Paul Davies C--- drivers/staging/lustre/lustre/obdclass/cl_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_lock.c b/drivers/staging/lustre/lustre/obdclass/cl_lock.c index 5621beb..6f83452 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_lock.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_lock.c @@ -687,7 +687,7 @@ EXPORT_SYMBOL(cl_lock_mutex_get); * * \see cl_lock_mutex_get() */ -int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) +static int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock) { int result; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] lustre: obdclass: fix sparse warning
On Sat, Oct 24, 2015 at 12:58:20PM +0530, Paul Davies C wrote: > This patch fixes the following warnings given by the sparse: > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: > symbol 'class_procfs_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: > symbol 'class_procfs_clean' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: > symbol 'obd_sysctl_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: > symbol 'obd_sysctl_clean' was not declared. Should it be static? > > Signed-off-by: Paul Davies C > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) This doesn't apply to my staging-testing branch of staging.git. Please rebase and resend, if it is still needed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] lustre: obdclass: fix sparse warning
On Sat, Oct 24, 2015 at 12:58:20PM +0530, Paul Davies C wrote: > This patch fixes the following warnings given by the sparse: > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: > symbol 'class_procfs_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: > symbol 'class_procfs_clean' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: > symbol 'obd_sysctl_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: > symbol 'obd_sysctl_clean' was not declared. Should it be static? > > Signed-off-by: Paul Davies C> --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) This doesn't apply to my staging-testing branch of staging.git. Please rebase and resend, if it is still needed. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lustre: obdclass: fix sparse warning
This patch fixes the following warnings given by the sparse: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static? Signed-off-by: Paul Davies C --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c index 6218ef3..45d92c2 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c @@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int class_procfs_init(void) +static int class_procfs_init(void) { int rc = -ENOMEM; struct dentry *file; @@ -457,7 +457,7 @@ out: return rc; } -int class_procfs_clean(void) +static int class_procfs_clean(void) { if (debugfs_lustre_root != NULL) debugfs_remove_recursive(debugfs_lustre_root); diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c index 1515163..6f13f21 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c @@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int obd_sysctl_init(void) +static int obd_sysctl_init(void) { return sysfs_create_group(lustre_kobj, _attr_group); } -void obd_sysctl_clean(void) +static void obd_sysctl_clean(void) { } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] lustre: obdclass: fix sparse warning
This patch fixes the following warnings given by the sparse: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static? Signed-off-by: Paul Davies C--- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c index 6218ef3..45d92c2 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c @@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int class_procfs_init(void) +static int class_procfs_init(void) { int rc = -ENOMEM; struct dentry *file; @@ -457,7 +457,7 @@ out: return rc; } -int class_procfs_clean(void) +static int class_procfs_clean(void) { if (debugfs_lustre_root != NULL) debugfs_remove_recursive(debugfs_lustre_root); diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c index 1515163..6f13f21 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c @@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int obd_sysctl_init(void) +static int obd_sysctl_init(void) { return sysfs_create_group(lustre_kobj, _attr_group); } -void obd_sysctl_clean(void) +static void obd_sysctl_clean(void) { } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/