Re: [PATCH] mac80211: don't warn about CW params when not using them

2019-07-18 Thread Brian Norris
On Thu, Jul 18, 2019 at 12:45 AM Stanislaw Gruszka wrote: > Fix looks fine for me. However I think rtw88 should implement > drv_conf_tx() because parameters can be different on different > network setups and maybe more important WMM/AC parameters become > quite recently part of ETSI regulatory. A

Re: [PATCH] mac80211: don't warn about CW params when not using them

2019-07-18 Thread Stanislaw Gruszka
On Wed, Jul 17, 2019 at 06:57:12PM -0700, Brian Norris wrote: > ieee80211_set_wmm_default() normally sets up the initial CW min/max for > each queue, except that it skips doing this if the driver doesn't > support ->conf_tx. We still end up calling drv_conf_tx() in some cases > (e.g., ieee80211_rec

[PATCH] mac80211: don't warn about CW params when not using them

2019-07-17 Thread Brian Norris
ieee80211_set_wmm_default() normally sets up the initial CW min/max for each queue, except that it skips doing this if the driver doesn't support ->conf_tx. We still end up calling drv_conf_tx() in some cases (e.g., ieee80211_reconfig()), which also still won't do anything useful...except it compla