Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Vlad Yasevich
On 05/19/2014 01:24 PM, Michael Spang wrote: > Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY > will result in an incorrect checksum if the packet is sent off the box. > > Cc: sta...@vger.kernel.org > Signed-off-by: Michael Spang > --- > drivers/net/macvlan.c | 4 +++- > 1

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Cong Wang
On Mon, May 19, 2014 at 1:05 PM, Michael Spang wrote: > On Mon, May 19, 2014 at 1:44 PM, Eric Dumazet wrote: >> >> I removed stable@ , as stable submissions are not done like that. >> > > Perhaps I've misunderstood something, but this suggestion is right > from

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Michael Spang
On Mon, May 19, 2014 at 1:44 PM, Eric Dumazet wrote: > > On Mon, 2014-05-19 at 13:24 -0400, Michael Spang wrote: > > Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY > > will result in an incorrect checksum if the packet is sent off the box. > > > > Cc: sta...@vger.kernel.org > >

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Eric Dumazet
On Mon, 2014-05-19 at 13:24 -0400, Michael Spang wrote: > Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY > will result in an incorrect checksum if the packet is sent off the box. > > Cc: sta...@vger.kernel.org > Signed-off-by: Michael Spang > --- > drivers/net/macvlan.c | 4

[PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Michael Spang
Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY will result in an incorrect checksum if the packet is sent off the box. Cc: sta...@vger.kernel.org Signed-off-by: Michael Spang --- drivers/net/macvlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Vlad Yasevich
On 05/19/2014 01:24 PM, Michael Spang wrote: Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY will result in an incorrect checksum if the packet is sent off the box. Cc: sta...@vger.kernel.org Signed-off-by: Michael Spang sp...@chromium.org --- drivers/net/macvlan.c | 4

[PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Michael Spang
Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY will result in an incorrect checksum if the packet is sent off the box. Cc: sta...@vger.kernel.org Signed-off-by: Michael Spang sp...@chromium.org --- drivers/net/macvlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Eric Dumazet
On Mon, 2014-05-19 at 13:24 -0400, Michael Spang wrote: Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY will result in an incorrect checksum if the packet is sent off the box. Cc: sta...@vger.kernel.org Signed-off-by: Michael Spang sp...@chromium.org ---

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Michael Spang
On Mon, May 19, 2014 at 1:44 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Mon, 2014-05-19 at 13:24 -0400, Michael Spang wrote: Changing ip_summed from CHECKSUM_PARTIAL to CHECKSUM_UNNECESSARY will result in an incorrect checksum if the packet is sent off the box. Cc:

Re: [PATCH] macvlan: Fix checksum errors when ip_summed is CHECKSUM_PARTIAL

2014-05-19 Thread Cong Wang
On Mon, May 19, 2014 at 1:05 PM, Michael Spang sp...@chromium.org wrote: On Mon, May 19, 2014 at 1:44 PM, Eric Dumazet eric.duma...@gmail.com wrote: I removed stable@ , as stable submissions are not done like that. Perhaps I've misunderstood something, but this suggestion is right from