Re: [PATCH] max3100 driver

2007-12-17 Thread Jiri Slaby
On 12/17/2007 09:55 AM, chri wrote: > On Dec 17, 2007 9:45 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: >> You probably wanted to unregister it after _all_ cards are removed, not after >> each... >> > > Hi, > > thanks you are right. I haven't noticed this since spi devices are not > hot-pluggable

Re: [PATCH] max3100 driver

2007-12-17 Thread chri
On Dec 17, 2007 9:45 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > > You probably wanted to unregister it after _all_ cards are removed, not after > each... > Hi, thanks you are right. I haven't noticed this since spi devices are not hot-pluggable so I could remove them only with rmmod (and so all

Re: [PATCH] max3100 driver

2007-12-17 Thread Jiri Slaby
On 12/17/2007 09:17 AM, [EMAIL PROTECTED] wrote: > This patch adds support for the MAX3100 SPI UART. > > Generated on 20071217 against v2.6.23 > > Signed-off-by: Christian Pellegrin <[EMAIL PROTECTED]> > --- > drivers/serial/Kconfig |7 + > drivers/serial/Makefile|1 +

[PATCH] max3100 driver

2007-12-17 Thread chripell
This patch adds support for the MAX3100 SPI UART. Generated on 20071217 against v2.6.23 Signed-off-by: Christian Pellegrin <[EMAIL PROTECTED]> --- drivers/serial/Kconfig |7 + drivers/serial/Makefile|1 + drivers/serial/max3100.c | 956

[PATCH] max3100 driver

2007-12-17 Thread chripell
This patch adds support for the MAX3100 SPI UART. Generated on 20071217 against v2.6.23 Signed-off-by: Christian Pellegrin [EMAIL PROTECTED] --- drivers/serial/Kconfig |7 + drivers/serial/Makefile|1 + drivers/serial/max3100.c | 956

Re: [PATCH] max3100 driver

2007-12-17 Thread Jiri Slaby
On 12/17/2007 09:17 AM, [EMAIL PROTECTED] wrote: This patch adds support for the MAX3100 SPI UART. Generated on 20071217 against v2.6.23 Signed-off-by: Christian Pellegrin [EMAIL PROTECTED] --- drivers/serial/Kconfig |7 + drivers/serial/Makefile|1 +

Re: [PATCH] max3100 driver

2007-12-17 Thread chri
On Dec 17, 2007 9:45 AM, Jiri Slaby [EMAIL PROTECTED] wrote: You probably wanted to unregister it after _all_ cards are removed, not after each... Hi, thanks you are right. I haven't noticed this since spi devices are not hot-pluggable so I could remove them only with rmmod (and so all of

Re: [PATCH] max3100 driver

2007-12-17 Thread Jiri Slaby
On 12/17/2007 09:55 AM, chri wrote: On Dec 17, 2007 9:45 AM, Jiri Slaby [EMAIL PROTECTED] wrote: You probably wanted to unregister it after _all_ cards are removed, not after each... Hi, thanks you are right. I haven't noticed this since spi devices are not hot-pluggable so I could

Re: [PATCH] max3100 driver

2007-12-12 Thread chri
Hi, thank you for your extensive review, I will fix and resubmitt. Anyway I learned an important lesson: checkpatch.pl will be my best friend. Sorry I haven't read about it earlier. Just a question: > > > +/* > > + * > > + * Copyright (C) 2007 Christian Pellegrin > > + * > > + * This program

Re: [PATCH] max3100 driver

2007-12-12 Thread Andrew Morton
On Wed, 5 Dec 2007 11:26:45 +0100 [EMAIL PROTECTED] wrote: > This patch adds support for the MAX3100 SPI UART. > Doesn't compile on x86_64: drivers/serial/max3100.c: In function 'startup': drivers/serial/max3100.c:706: error: 'IRQT_FALLING' undeclared (first use in this function)

Re: [PATCH] max3100 driver

2007-12-12 Thread Andrew Morton
On Wed, 5 Dec 2007 11:26:45 +0100 [EMAIL PROTECTED] wrote: This patch adds support for the MAX3100 SPI UART. Doesn't compile on x86_64: drivers/serial/max3100.c: In function 'startup': drivers/serial/max3100.c:706: error: 'IRQT_FALLING' undeclared (first use in this function)

Re: [PATCH] max3100 driver

2007-12-12 Thread chri
Hi, thank you for your extensive review, I will fix and resubmitt. Anyway I learned an important lesson: checkpatch.pl will be my best friend. Sorry I haven't read about it earlier. Just a question: +/* + * + * Copyright (C) 2007 Christian Pellegrin + * + * This program is free

[PATCH] max3100 driver

2007-12-05 Thread chripell
This patch adds support for the MAX3100 SPI UART. Generated on 20071205 against v2.6.23 Signed-off-by: Christian Pellegrin <[EMAIL PROTECTED]> --- drivers/serial/Kconfig |7 + drivers/serial/Makefile|1 + drivers/serial/max3100.c | 960

[PATCH] max3100 driver

2007-12-05 Thread chripell
This patch adds support for the MAX3100 SPI UART. Generated on 20071205 against v2.6.23 Signed-off-by: Christian Pellegrin [EMAIL PROTECTED] --- drivers/serial/Kconfig |7 + drivers/serial/Makefile|1 + drivers/serial/max3100.c | 960