Re: [PATCH] max732x_probe: remove redundant check

czw., 18 cze 2020 o 01:58 Gaurav Singh napisał(a): > > The check : if (pdata) is redundant since its already > dereferenced before: pdata->have_64bit_regs; > pdata is not initialized after that hence remove > this null check. > > Signed-off-by: Gaurav Singh > --- > drivers/gpio/gpio-max732x.c |

[PATCH] max732x_probe: remove redundant check

The pdata is already checked for its validity. Remove the redundant check. Signed-off-by: Gaurav Singh --- drivers/gpio/gpio-max732x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 5fb0bcf31142..63472f308857

Re: [PATCH] max732x_probe: remove redundant check

On Wed, Jun 10, 2020 at 1:36 PM Gaurav Singh wrote: > Signed-off-by: Gaurav Singh > > The pdata is already checked for its validity. Remove > this redundant check. Patch applied. Please put signed-off-by at the end of the mail. Yours, Linus Walleij

[PATCH] max732x_probe: remove redundant check

The check : if (pdata) is redundant since its already dereferenced before: pdata->have_64bit_regs; pdata is not initialized after that hence remove this null check. Signed-off-by: Gaurav Singh --- drivers/gpio/gpio-max732x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] max732x_probe: remove redundant check

Signed-off-by: Gaurav Singh The pdata is already checked for its validity. Remove this redundant check. --- drivers/gpio/gpio-max732x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c index 5fb0bcf31142..63472f308857

Re: [PATCH] max732x_probe: remove redundant check

On Sat, Jun 6, 2020 at 5:09 PM gaurav singh wrote: > The pdata is already checked for its validity above: > > if (!pdata) { > dev_dbg(>dev, "no platform data\n"); > return -EINVAL; > } > > So no need to check again. Hence remove the if (pdata) part. Please find the >