Re: [PATCH] mballoc: Replace seq_printf with seq_puts

2020-08-18 Thread Theodore Y. Ts'o
On Mon, Aug 10, 2020 at 02:21:58AM +, Xu Wang wrote:
> seq_puts is a lot cheaper than seq_printf, so use that to print
> literal strings.
> 
> Signed-off-by: Xu Wang 

Applied, thanks.

- Ted


Re: [PATCH] mballoc: Replace seq_printf with seq_puts

2020-08-10 Thread Ritesh Harjani




On 8/10/20 7:51 AM, Xu Wang wrote:

seq_puts is a lot cheaper than seq_printf, so use that to print
literal strings.

Signed-off-by: Xu Wang 


Looks good to me.
Reviewed-by: Ritesh Harjani 


[PATCH] mballoc: Replace seq_printf with seq_puts

2020-08-09 Thread Xu Wang
seq_puts is a lot cheaper than seq_printf, so use that to print
literal strings.

Signed-off-by: Xu Wang 
---
 fs/ext4/mballoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index c0a331e2feb0..77288e549a95 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2439,7 +2439,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, 
void *v)
for (i = 0; i <= 13; i++)
seq_printf(seq, " %-5u", i <= blocksize_bits + 1 ?
sg.info.bb_counters[i] : 0);
-   seq_printf(seq, " ]\n");
+   seq_puts(seq, " ]\n");
 
return 0;
 }
-- 
2.17.1