Re: [PATCH] md: Fix for raid6 reshape.

2007-03-05 Thread Neil Brown
On Friday March 2, [EMAIL PROTECTED] wrote: > > > >>> + conf->expand_progress = (sector_nr + i) * new_data_disks; > >>> > Will the (real) fix be in 2.6.21? It is now in Linus' git tree, so yes. NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-05 Thread Neil Brown
On Friday March 2, [EMAIL PROTECTED] wrote: + conf-expand_progress = (sector_nr + i) * new_data_disks; Will the (real) fix be in 2.6.21? It is now in Linus' git tree, so yes. NeilBrown - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-02 Thread Bill Davidsen
Neil Brown wrote: On Thursday March 1, [EMAIL PROTECTED] wrote: On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: - conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1); + conf->expand_progress = (sector_nr + i) * new_data_disks); ahem.

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-02 Thread Bill Davidsen
Neil Brown wrote: On Thursday March 1, [EMAIL PROTECTED] wrote: On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown [EMAIL PROTECTED] wrote: - conf-expand_progress = (sector_nr + i)*(conf-raid_disks-1); + conf-expand_progress = (sector_nr + i) * new_data_disks); ahem.

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread Neil Brown
On Thursday March 1, [EMAIL PROTECTED] wrote: > On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: > > > - conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1); > > + conf->expand_progress = (sector_nr + i) * new_data_disks); > > ahem. It wasn't like that when I

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown <[EMAIL PROTECTED]> wrote: > - conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1); > + conf->expand_progress = (sector_nr + i) * new_data_disks); ahem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread NeilBrown
### Comments for Changeset Recent patch for raid6 reshape had a change missing that showed up in subsequent review. Many places in the raid5 code used "conf->raid_disks-1" to mean "number of data disks". With raid6 that had to be changed to "conf->raid_disk - conf->max_degraded" or similar.

[PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread NeilBrown
### Comments for Changeset Recent patch for raid6 reshape had a change missing that showed up in subsequent review. Many places in the raid5 code used conf-raid_disks-1 to mean number of data disks. With raid6 that had to be changed to conf-raid_disk - conf-max_degraded or similar. One place

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown [EMAIL PROTECTED] wrote: - conf-expand_progress = (sector_nr + i)*(conf-raid_disks-1); + conf-expand_progress = (sector_nr + i) * new_data_disks); ahem. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] md: Fix for raid6 reshape.

2007-03-01 Thread Neil Brown
On Thursday March 1, [EMAIL PROTECTED] wrote: On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown [EMAIL PROTECTED] wrote: - conf-expand_progress = (sector_nr + i)*(conf-raid_disks-1); + conf-expand_progress = (sector_nr + i) * new_data_disks); ahem. It wasn't like that when I tested it,