Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
Hi, On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad wrote: > Hi Mauro, > > On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab > wrote: >> Em Tue, 18 Nov 2014 10:57:48 + > [Snip] >> >> -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) >> +static int get_plane_info(str

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Prabhakar Lad
Hi Mauro, On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab wrote: > Em Tue, 18 Nov 2014 10:57:48 + [Snip] > > -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) > +static int get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index, u32 > *ret_addr) > { >

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Mauro Carvalho Chehab
losed patch will be doing a better job fixing it. Still, the entire code seems mostly useless on my eyes, as this function seems to be used only for debugging purposes, and errors there aren't actually handled properly. [PATCH] [media] exynos-gsc: fix build warning Fixes followin

[PATCH] media: exynos-gsc: fix build warning

2014-11-18 Thread Lad, Prabhakar
this patch fixes following build warning: gsc-core.c:350:17: warning: 'low_plane' may be used uninitialized gsc-core.c:371:31: warning: 'high_plane' may be used uninitialized Signed-off-by: Lad, Prabhakar --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- 1 file changed, 2 insertions(+)