Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Hans Verkuil
On 02/02/15 11:44, Hans Verkuil wrote: > Hi Pablo, Jean-Michel, > > On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: >> This is a preliminary patch in order to add support for ALSA. >> It replaces all current i2c access with regmap. >> Add the registers which will then be used too, as these

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Lars-Peter Clausen
On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: Looks mostly good, some things in addition to what Hans already said. [...] - -static s32 adv_smbus_write_byte_data(struct adv7604_state *state, -enum adv7604_page page, u8 command, -

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Lars-Peter Clausen
On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: Looks mostly good, some things in addition to what Hans already said. [...] - -static s32 adv_smbus_write_byte_data(struct adv7604_state *state, -enum adv7604_page page, u8 command, -

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Hans Verkuil
On 02/02/15 11:44, Hans Verkuil wrote: Hi Pablo, Jean-Michel, On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Add the registers which will then be used too, as these are

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-02 Thread Hans Verkuil
Hi Pablo, Jean-Michel, On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: > This is a preliminary patch in order to add support for ALSA. > It replaces all current i2c access with regmap. > Add the registers which will then be used too, as these are declared at init. > > Signed-off-by: Pablo

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-02 Thread Hans Verkuil
Hi Pablo, Jean-Michel, On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Add the registers which will then be used too, as these are declared at init. Signed-off-by: Pablo Anton

[PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-01 Thread Jean-Michel Hautbois
This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Add the registers which will then be used too, as these are declared at init. Signed-off-by: Pablo Anton Signed-off-by: Jean-Michel Hautbois --- drivers/media/i2c/adv7604.c | 428

[PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-01 Thread Jean-Michel Hautbois
This is a preliminary patch in order to add support for ALSA. It replaces all current i2c access with regmap. Add the registers which will then be used too, as these are declared at init. Signed-off-by: Pablo Anton pablo.an...@vodalys-labs.com Signed-off-by: Jean-Michel Hautbois