Re: [PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type
Acked-by: Brad LoveOn 2018-04-24 08:19, Luc Van Oostenryck wrote: > The method dvb_frontend_ops::search() is defined as > returning an 'enum dvbfe_search', but the implementation in this > driver returns an 'int'. > > Fix this by returning 'enum dvbfe_search' in this driver too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/media/dvb-frontends/lgdt3306a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/lgdt3306a.c > b/drivers/media/dvb-frontends/lgdt3306a.c > index 7eb4e1469..32de82447 100644 > --- a/drivers/media/dvb-frontends/lgdt3306a.c > +++ b/drivers/media/dvb-frontends/lgdt3306a.c > @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct > dvb_frontend *fe, > return 0; > } > > -static int lgdt3306a_search(struct dvb_frontend *fe) > +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe) > { > enum fe_status status = 0; > int ret;
Re: [PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type
Acked-by: Brad Love On 2018-04-24 08:19, Luc Van Oostenryck wrote: > The method dvb_frontend_ops::search() is defined as > returning an 'enum dvbfe_search', but the implementation in this > driver returns an 'int'. > > Fix this by returning 'enum dvbfe_search' in this driver too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/media/dvb-frontends/lgdt3306a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/lgdt3306a.c > b/drivers/media/dvb-frontends/lgdt3306a.c > index 7eb4e1469..32de82447 100644 > --- a/drivers/media/dvb-frontends/lgdt3306a.c > +++ b/drivers/media/dvb-frontends/lgdt3306a.c > @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct > dvb_frontend *fe, > return 0; > } > > -static int lgdt3306a_search(struct dvb_frontend *fe) > +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe) > { > enum fe_status status = 0; > int ret;
[PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type
The method dvb_frontend_ops::search() is defined as returning an 'enum dvbfe_search', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_search' in this driver too. Signed-off-by: Luc Van Oostenryck--- drivers/media/dvb-frontends/lgdt3306a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 7eb4e1469..32de82447 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct dvb_frontend *fe, return 0; } -static int lgdt3306a_search(struct dvb_frontend *fe) +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe) { enum fe_status status = 0; int ret; -- 2.17.0
[PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type
The method dvb_frontend_ops::search() is defined as returning an 'enum dvbfe_search', but the implementation in this driver returns an 'int'. Fix this by returning 'enum dvbfe_search' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/media/dvb-frontends/lgdt3306a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c index 7eb4e1469..32de82447 100644 --- a/drivers/media/dvb-frontends/lgdt3306a.c +++ b/drivers/media/dvb-frontends/lgdt3306a.c @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct dvb_frontend *fe, return 0; } -static int lgdt3306a_search(struct dvb_frontend *fe) +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe) { enum fe_status status = 0; int ret; -- 2.17.0