Re: [SIL2review] [PATCH] media: tc358743: release device_node in tc358743_probe_of()

2018-05-26 Thread Nicholas Mc Guire
On Sat, May 26, 2018 at 12:54:00AM +0300, Alexey Khoroshilov wrote: > of_graph_get_next_endpoint() returns device_node with refcnt increased, > but these is no of_node_put() for it. I think this is correct - but would it not be simpler to do endpoint =

Re: [SIL2review] [PATCH] media: tc358743: release device_node in tc358743_probe_of()

2018-05-26 Thread Nicholas Mc Guire
On Sat, May 26, 2018 at 12:54:00AM +0300, Alexey Khoroshilov wrote: > of_graph_get_next_endpoint() returns device_node with refcnt increased, > but these is no of_node_put() for it. I think this is correct - but would it not be simpler to do endpoint =

[PATCH] media: tc358743: release device_node in tc358743_probe_of()

2018-05-25 Thread Alexey Khoroshilov
of_graph_get_next_endpoint() returns device_node with refcnt increased, but these is no of_node_put() for it. The patch adds one on error and normal paths. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

[PATCH] media: tc358743: release device_node in tc358743_probe_of()

2018-05-25 Thread Alexey Khoroshilov
of_graph_get_next_endpoint() returns device_node with refcnt increased, but these is no of_node_put() for it. The patch adds one on error and normal paths. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/i2c/tc358743.c | 5