Re: [PATCH] media: uvcvideo: Read support

2019-03-05 Thread Laurent Pinchart
Hi Hugues, On Tue, Mar 05, 2019 at 10:24:15AM +, Hugues FRUCHET wrote: > On 3/4/19 4:44 PM, Laurent Pinchart wrote: > > On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: > >> On 04/03/2019 12:35, Hugues Fruchet wrote: > >>> Add support of read() call from userspace by

Re: [PATCH] media: uvcvideo: Read support

2019-03-05 Thread Hugues FRUCHET
Hi Kieran, Laurent, On 3/4/19 4:44 PM, Laurent Pinchart wrote: > Hello, > > On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: >> On 04/03/2019 12:35, Hugues Fruchet wrote: >>> Add support of read() call from userspace by implementing >>> uvc_v4l2_read() with vb2_read() helper. >>

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Laurent Pinchart
Hello, On Mon, Mar 04, 2019 at 03:36:32PM +, Kieran Bingham wrote: > On 04/03/2019 12:35, Hugues Fruchet wrote: > > Add support of read() call from userspace by implementing > > uvc_v4l2_read() with vb2_read() helper. > > Just thinking out loud, > > This opens up UVC devices to read raw

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Kieran Bingham
Hi Hughes, On 04/03/2019 12:35, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. Just thinking out loud, This opens up UVC devices to read raw full frame images through this interface as well. Due to the UVC protocol,

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hans Verkuil
On 3/4/19 1:35 PM, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. > > Signed-off-by: Hugues Fruchet > --- > drivers/media/usb/uvc/uvc_queue.c | 15 ++- > drivers/media/usb/uvc/uvc_v4l2.c | 11 --- >

Re: [PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hans Verkuil
On 3/4/19 1:35 PM, Hugues Fruchet wrote: > Add support of read() call from userspace by implementing > uvc_v4l2_read() with vb2_read() helper. > > Signed-off-by: Hugues Fruchet > --- > drivers/media/usb/uvc/uvc_queue.c | 15 ++- > drivers/media/usb/uvc/uvc_v4l2.c | 11 --- >

[PATCH] media: uvcvideo: Read support

2019-03-04 Thread Hugues Fruchet
Add support of read() call from userspace by implementing uvc_v4l2_read() with vb2_read() helper. Signed-off-by: Hugues Fruchet --- drivers/media/usb/uvc/uvc_queue.c | 15 ++- drivers/media/usb/uvc/uvc_v4l2.c | 11 --- drivers/media/usb/uvc/uvcvideo.h | 2 ++ 3 files