Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Laurent Pinchart
Hi Hans, On Tuesday 02 December 2014 20:34:22 Hans Verkuil wrote: > On 12/02/2014 01:59 PM, Laurent Pinchart wrote: > Basically, > > 1. Create a subdev pad configuration store structure to store the > formats and selection rectangles for each pad. > >>> > >>> I wouldn't call

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Hans Verkuil
Hi Laurent, On 12/02/2014 01:59 PM, Laurent Pinchart wrote: Basically, 1. Create a subdev pad configuration store structure to store the formats and selection rectangles for each pad. >>> >>> I wouldn't call it a 'store'. Just call it fmt_config or pad_config >>> something

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Laurent Pinchart
Hi Hans, On Tuesday 02 December 2014 13:53:05 Hans Verkuil wrote: > On 12/02/14 08:45, Hans Verkuil wrote: > > On 12/02/2014 12:26 AM, Laurent Pinchart wrote: > >> On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: > >>> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: > On

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Hans Verkuil
On 12/02/14 08:45, Hans Verkuil wrote: > On 12/02/2014 12:26 AM, Laurent Pinchart wrote: >> Hi Prabhakar, >> >> On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: >>> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: >

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Hans Verkuil
On 12/02/14 08:45, Hans Verkuil wrote: On 12/02/2014 12:26 AM, Laurent Pinchart wrote: Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29,

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Laurent Pinchart
Hi Hans, On Tuesday 02 December 2014 13:53:05 Hans Verkuil wrote: On 12/02/14 08:45, Hans Verkuil wrote: On 12/02/2014 12:26 AM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Hans Verkuil
Hi Laurent, On 12/02/2014 01:59 PM, Laurent Pinchart wrote: Basically, 1. Create a subdev pad configuration store structure to store the formats and selection rectangles for each pad. I wouldn't call it a 'store'. Just call it fmt_config or pad_config something like that. Sure, the name

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-02 Thread Laurent Pinchart
Hi Hans, On Tuesday 02 December 2014 20:34:22 Hans Verkuil wrote: On 12/02/2014 01:59 PM, Laurent Pinchart wrote: Basically, 1. Create a subdev pad configuration store structure to store the formats and selection rectangles for each pad. I wouldn't call it a 'store'. Just call it

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: >> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: >> > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: >> >> On Sat, Nov 29, 2014 at

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Hans Verkuil
On 12/02/2014 12:26 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: >> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: >>> On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Laurent Pinchart
Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: > On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: > > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: > >> On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: > >> > Hi Prabhakar, > >> > >> [Snip] > >>

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Laurent Pinchart
Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] Sure. That's a

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Hans Verkuil
On 12/02/2014 12:26 AM, Laurent Pinchart wrote: Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote:

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-12-01 Thread Prabhakar Lad
Hi Hans, On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote: On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote: > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: >> On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: >> > Hi Prabhakar, >> >> [Snip] >> >> >> > Sure. That's a better choice than removing the config option

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Laurent Pinchart
On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: > On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > [Snip] > > >> > Sure. That's a better choice than removing the config option dependency > >> > of the fields struct v4l2_subdev. > > > > Decoupling

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: > Hi Prabhakar, > [Snip] >> > Sure. That's a better choice than removing the config option dependency of >> > the fields struct v4l2_subdev. > > Decoupling CONFIG_VIDEO_V4L2_SUBDEV_API from the availability of the in-kernel >

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, [Snip] Sure. That's a better choice than removing the config option dependency of the fields struct v4l2_subdev. Decoupling CONFIG_VIDEO_V4L2_SUBDEV_API from the

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Laurent Pinchart
On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] Sure. That's a better choice than removing the config option dependency of the fields struct v4l2_subdev. Decoupling

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-30 Thread Prabhakar Lad
Hi Laurent, On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote: On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote: Hi Prabhakar, [Snip] Sure. That's a better choice than removing the

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Laurent Pinchart
Hi Prabhakar, On Saturday 29 November 2014 18:30:09 Prabhakar Lad wrote: > On Tue, Nov 18, 2014 at 6:07 PM, Sakari Ailus wrote: > > On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: > >> On 11/17/14 11:41, Lad, Prabhakar wrote: > >> > this patch removes the guard

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Prabhakar Lad
Hi Laurent, On Tue, Nov 18, 2014 at 6:07 PM, Sakari Ailus wrote: > Hi Hans and Prabhakar, > > On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: >> On 11/17/14 11:41, Lad, Prabhakar wrote: >> > this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API >> > for v4l2_subdev_get_try_*()

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Prabhakar Lad
Hi Laurent, On Tue, Nov 18, 2014 at 6:07 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Hans and Prabhakar, On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: On 11/17/14 11:41, Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-29 Thread Laurent Pinchart
Hi Prabhakar, On Saturday 29 November 2014 18:30:09 Prabhakar Lad wrote: On Tue, Nov 18, 2014 at 6:07 PM, Sakari Ailus sakari.ai...@iki.fi wrote: On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: On 11/17/14 11:41, Lad, Prabhakar wrote: this patch removes the guard

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Sakari Ailus
Hi Hans and Prabhakar, On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: > On 11/17/14 11:41, Lad, Prabhakar wrote: > > this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API > > for v4l2_subdev_get_try_*() functions. > > In cases where a subdev using v4l2_subdev_get_try_*() calls

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Prabhakar Lad
Hi Hans, On Tue, Nov 18, 2014 at 9:39 AM, Hans Verkuil wrote: > On 11/17/14 11:41, Lad, Prabhakar wrote: >> this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API >> for v4l2_subdev_get_try_*() functions. >> In cases where a subdev using v4l2_subdev_get_try_*() calls >> internally and the

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Hans Verkuil
On 11/17/14 11:41, Lad, Prabhakar wrote: > this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API > for v4l2_subdev_get_try_*() functions. > In cases where a subdev using v4l2_subdev_get_try_*() calls > internally and the bridge using subdev pad ops which is > not MC aware forces to select

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Sakari Ailus
Hi Hans and Prabhakar, On Tue, Nov 18, 2014 at 10:39:24AM +0100, Hans Verkuil wrote: On 11/17/14 11:41, Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Hans Verkuil
On 11/17/14 11:41, Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally and the bridge using subdev pad ops which is not MC aware forces to select

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-18 Thread Prabhakar Lad
Hi Hans, On Tue, Nov 18, 2014 at 9:39 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 11/17/14 11:41, Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Prabhakar Lad
Hi Sakari, On Mon, Nov 17, 2014 at 10:53 AM, Sakari Ailus wrote: > Hi Prabhakar, > > Thank you for the patch. > > Lad, Prabhakar wrote: >> >> this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API >> for v4l2_subdev_get_try_*() functions. >> In cases where a subdev using

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Sakari Ailus
Hi Prabhakar, Thank you for the patch. Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally and the bridge using subdev pad ops which is not MC aware forces

[PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Lad, Prabhakar
this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally and the bridge using subdev pad ops which is not MC aware forces to select MEDIA_CONTROLLER, as VIDEO_V4L2_SUBDEV_API is dependent

[PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Lad, Prabhakar
this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally and the bridge using subdev pad ops which is not MC aware forces to select MEDIA_CONTROLLER, as VIDEO_V4L2_SUBDEV_API is dependent

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Sakari Ailus
Hi Prabhakar, Thank you for the patch. Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using v4l2_subdev_get_try_*() calls internally and the bridge using subdev pad ops which is not MC aware forces

Re: [PATCH] media: v4l2-subdev.h: drop the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*()

2014-11-17 Thread Prabhakar Lad
Hi Sakari, On Mon, Nov 17, 2014 at 10:53 AM, Sakari Ailus sakari.ai...@linux.intel.com wrote: Hi Prabhakar, Thank you for the patch. Lad, Prabhakar wrote: this patch removes the guard CONFIG_VIDEO_V4L2_SUBDEV_API for v4l2_subdev_get_try_*() functions. In cases where a subdev using