Re: [PATCH] media: vimc: fla: Add virtual flash subdevice

2019-09-10 Thread Hans Verkuil
On 9/10/19 1:00 AM, Lucas Magalhães wrote: > Hi Hans, > Thanks for the review. I fixed most of the issues you found. Just have > the question below. > > On Mon, Sep 2, 2019 at 9:04 AM Hans Verkuil wrote: >> >>> + >>> +int vimc_fla_add(struct vimc_device *vimc, struct vimc_ent_config *vcfg) >>>

Re: [PATCH] media: vimc: fla: Add virtual flash subdevice

2019-09-09 Thread Lucas Magalhães
Hi Hans, Thanks for the review. I fixed most of the issues you found. Just have the question below. On Mon, Sep 2, 2019 at 9:04 AM Hans Verkuil wrote: > > > + > > +int vimc_fla_add(struct vimc_device *vimc, struct vimc_ent_config *vcfg) > > +{ > > + struct v4l2_device *v4l2_dev = >v4l2_dev;

Re: [PATCH] media: vimc: fla: Add virtual flash subdevice

2019-09-02 Thread Hans Verkuil
Hi Lucas, Eduardo, Thank you for the patch! Some comments below: On 9/1/19 11:11 PM, Lucas A. M. Magalhães wrote: > From: Lucas A. M. Magalhaes > > Add a virtual subdevice to simulate the flash control API. > Those are the supported controls: > v4l2-ctl -d /dev/v4l-subdev6 -L > Flash Controls

[PATCH] media: vimc: fla: Add virtual flash subdevice

2019-09-01 Thread Lucas A . M . Magalhães
From: Lucas A. M. Magalhaes Add a virtual subdevice to simulate the flash control API. Those are the supported controls: v4l2-ctl -d /dev/v4l-subdev6 -L Flash Controls led_mode 0x009c0901 (menu) : min=0 max=2 default=0 value=0 0: Off