Re: [PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-18 Thread Dan Carpenter
On Wed, Jan 13, 2021 at 05:13:41PM +0100, Hans Verkuil wrote: > Hi Dan, > > On 06/01/2021 11:10, Dan Carpenter wrote: > > Syzbot discovered that the probe error handling doesn't clean up the > > resources allocated in zr364xx_board_init(). There are several > > related bugs in this code so I

Re: [PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-13 Thread Hans Verkuil
Hi Dan, On 06/01/2021 11:10, Dan Carpenter wrote: > Syzbot discovered that the probe error handling doesn't clean up the > resources allocated in zr364xx_board_init(). There are several > related bugs in this code so I have re-written the error handling. > > 1) Introduce a new function

Re: [PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-06 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 11:45:50AM -0500, Alan Stern wrote: > On Wed, Jan 06, 2021 at 01:10:05PM +0300, Dan Carpenter wrote: > > Syzbot discovered that the probe error handling doesn't clean up the > > resources allocated in zr364xx_board_init(). There are several > > related bugs in this code so

Re: [PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-06 Thread Alan Stern
On Wed, Jan 06, 2021 at 01:10:05PM +0300, Dan Carpenter wrote: > Syzbot discovered that the probe error handling doesn't clean up the > resources allocated in zr364xx_board_init(). There are several > related bugs in this code so I have re-written the error handling. Dan: I recently sent in a

[PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-06 Thread Dan Carpenter
Syzbot discovered that the probe error handling doesn't clean up the resources allocated in zr364xx_board_init(). There are several related bugs in this code so I have re-written the error handling. 1) Introduce a new function zr364xx_board_uninit() which cleans up the resources in