Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-24 Thread Andrew Morton
On Tue, 24 Sep 2019 12:53:55 +0200 Michal Hocko wrote: > Andrew, do you plan to send this patch to Linus as ell? I suppose so. We don't actually have any reviewed-bys or acked-bys but I expect that's because Shakeel forgot to type them in. The followup deprecation warning patch I parked for

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-24 Thread Michal Hocko
Andrew, do you plan to send this patch to Linus as ell? On Fri 06-09-19 14:56:08, Michal Hocko wrote: > From: Michal Hocko > > Thomas has noticed the following NULL ptr dereference when using cgroup > v1 kmem limit: > BUG: unable to handle kernel NULL pointer dereference at 0008 >

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-12 Thread Shakeel Butt
On Wed, Sep 11, 2019 at 8:16 AM Michal Hocko wrote: > > On Wed 11-09-19 07:37:40, Andrew Morton wrote: > > On Wed, 11 Sep 2019 14:00:02 +0200 Michal Hocko wrote: > > > > > On Mon 09-09-19 13:22:45, Michal Hocko wrote: > > > > On Fri 06-09-19 11:24:55, Shakeel Butt wrote: > > > [...] > > > > > I

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-11 Thread Michal Hocko
On Wed 11-09-19 07:37:40, Andrew Morton wrote: > On Wed, 11 Sep 2019 14:00:02 +0200 Michal Hocko wrote: > > > On Mon 09-09-19 13:22:45, Michal Hocko wrote: > > > On Fri 06-09-19 11:24:55, Shakeel Butt wrote: > > [...] > > > > I wonder what has changed since > > > >

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-11 Thread Andrew Morton
On Wed, 11 Sep 2019 14:00:02 +0200 Michal Hocko wrote: > On Mon 09-09-19 13:22:45, Michal Hocko wrote: > > On Fri 06-09-19 11:24:55, Shakeel Butt wrote: > [...] > > > I wonder what has changed since > > > . > > > > I have

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-11 Thread Michal Hocko
On Mon 09-09-19 13:22:45, Michal Hocko wrote: > On Fri 06-09-19 11:24:55, Shakeel Butt wrote: [...] > > I wonder what has changed since > > . > > I have completely forgot about that one. It seems that we have just > repeated

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-09 Thread Michal Hocko
On Fri 06-09-19 11:24:55, Shakeel Butt wrote: > On Fri, Sep 6, 2019 at 5:56 AM Michal Hocko wrote: > > > > From: Michal Hocko > > > > Thomas has noticed the following NULL ptr dereference when using cgroup > > v1 kmem limit: > > BUG: unable to handle kernel NULL pointer dereference at

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-06 Thread Shakeel Butt
On Fri, Sep 6, 2019 at 5:56 AM Michal Hocko wrote: > > From: Michal Hocko > > Thomas has noticed the following NULL ptr dereference when using cgroup > v1 kmem limit: > BUG: unable to handle kernel NULL pointer dereference at 0008 > PGD 0 > P4D 0 > Oops: [#1] PREEMPT SMP PTI >

[PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-06 Thread Michal Hocko
From: Michal Hocko Thomas has noticed the following NULL ptr dereference when using cgroup v1 kmem limit: BUG: unable to handle kernel NULL pointer dereference at 0008 PGD 0 P4D 0 Oops: [#1] PREEMPT SMP PTI CPU: 3 PID: 16923 Comm: gtk-update-icon Not tainted 4.19.51 #42 Hardware