Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-17 Thread Lee Jones
On Wed, 11 Nov 2020, Tony Lindgren wrote: > With commit 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack > registers"), the cpcap interrupts are no longer getting acked properly > leading to a very unresponsive device with CPUs fully loaded spinning > in the threaded IRQ handlers. > > To me

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-16 Thread Mark Brown
On Mon, Nov 16, 2020 at 12:43:57PM -0800, Tim Harvey wrote: > What are your thoughts regarding the issue of regmap_irq_sync_unlock > ack_invert ack'ing by writing ~d->mask_buf[i] which ends up setting > all the other bits not trying to be awk'd? I would say that the device > allowing an

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-16 Thread Tim Harvey
On Sun, Nov 15, 2020 at 12:43 AM Tony Lindgren wrote: > > * Tim Harvey [201113 22:07]: > > 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack registers") > > appears to not only add the new clear_ack case it also attempts to > > resolve the long standing ack_invert issue with this change: > >

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-16 Thread Tim Harvey
On Mon, Nov 16, 2020 at 10:59 AM Mark Brown wrote: > > On Fri, Nov 13, 2020 at 02:06:29PM -0800, Tim Harvey wrote: > > > asserted? I'm also wondering if my issue is that I currently have the > > interrupt registered as such: > > > ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq, > >

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-16 Thread Mark Brown
On Fri, Nov 13, 2020 at 02:06:29PM -0800, Tim Harvey wrote: > asserted? I'm also wondering if my issue is that I currently have the > interrupt registered as such: > ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq, > IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_FALLING, 0, _irq_chip, >

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-15 Thread Pavel Machek
Hi! > With commit 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack > registers"), the cpcap interrupts are no longer getting acked properly > leading to a very unresponsive device with CPUs fully loaded spinning > in the threaded IRQ handlers. > > To me it looks like the clear_ack commit

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-15 Thread Tony Lindgren
* Tim Harvey [201113 22:07]: > 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack registers") > appears to not only add the new clear_ack case it also attempts to > resolve the long standing ack_invert issue with this change: > > - ret = regmap_write(map, reg, data->status_buf[i]); > + if

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-13 Thread Tim Harvey
On Fri, Nov 13, 2020 at 2:21 AM Lee Jones wrote: > > On Wed, 11 Nov 2020, Tony Lindgren wrote: > > > With commit 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack > > registers"), the cpcap interrupts are no longer getting acked properly > > leading to a very unresponsive device with CPUs

Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-13 Thread Lee Jones
On Wed, 11 Nov 2020, Tony Lindgren wrote: > With commit 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack > registers"), the cpcap interrupts are no longer getting acked properly > leading to a very unresponsive device with CPUs fully loaded spinning > in the threaded IRQ handlers. > > To me

[PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack

2020-11-11 Thread Tony Lindgren
With commit 3a6f0fb7b8eb ("regmap: irq: Add support to clear ack registers"), the cpcap interrupts are no longer getting acked properly leading to a very unresponsive device with CPUs fully loaded spinning in the threaded IRQ handlers. To me it looks like the clear_ack commit above actually fixed