Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-15 Thread Alexandre Courbot
On Wed, Jun 15, 2016 at 1:50 AM, Rhyland Klein wrote: > On 6/7/2016 4:05 AM, Lee Jones wrote: >> On Thu, 12 May 2016, Rhyland Klein wrote: >> >>> When configuring FPS during probe, assuming a DT node is present for >>> FPS, the code can run into a problem with the switch

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-15 Thread Alexandre Courbot
On Wed, Jun 15, 2016 at 1:50 AM, Rhyland Klein wrote: > On 6/7/2016 4:05 AM, Lee Jones wrote: >> On Thu, 12 May 2016, Rhyland Klein wrote: >> >>> When configuring FPS during probe, assuming a DT node is present for >>> FPS, the code can run into a problem with the switch statements in >>>

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-14 Thread Rhyland Klein
On 6/7/2016 4:05 AM, Lee Jones wrote: > On Thu, 12 May 2016, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_get_fps_period_reg_value().

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-14 Thread Rhyland Klein
On 6/7/2016 4:05 AM, Lee Jones wrote: > On Thu, 12 May 2016, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and max77620_get_fps_period_reg_value().

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-07 Thread Lee Jones
On Thu, 12 May 2016, Rhyland Klein wrote: > When configuring FPS during probe, assuming a DT node is present for > FPS, the code can run into a problem with the switch statements in > max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > in the case of chip->chip_id ==

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-07 Thread Lee Jones
On Thu, 12 May 2016, Rhyland Klein wrote: > When configuring FPS during probe, assuming a DT node is present for > FPS, the code can run into a problem with the switch statements in > max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > in the case of chip->chip_id ==

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-06 Thread Thierry Reding
On Tue, May 31, 2016 at 08:30:22AM +0100, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > > > On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > > > > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > > >> When configuring FPS during probe, assuming a DT node is present for

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-06 Thread Thierry Reding
On Tue, May 31, 2016 at 08:30:22AM +0100, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > > > On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > > > > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > > >> When configuring FPS during probe, assuming a DT node is present for

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-01 Thread Rhyland Klein
On 5/31/2016 3:30 AM, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > >> On 5/12/2016 1:52 PM, Laxman Dewangan wrote: >>> >>> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: When configuring FPS during probe, assuming a DT node is present for FPS, the code can run

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-06-01 Thread Rhyland Klein
On 5/31/2016 3:30 AM, Lee Jones wrote: > On Fri, 27 May 2016, Rhyland Klein wrote: > >> On 5/12/2016 1:52 PM, Laxman Dewangan wrote: >>> >>> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: When configuring FPS during probe, assuming a DT node is present for FPS, the code can run

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-31 Thread Lee Jones
On Fri, 27 May 2016, Rhyland Klein wrote: > On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for > >> FPS, the code can run into a problem with the switch statements

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-31 Thread Lee Jones
On Fri, 27 May 2016, Rhyland Klein wrote: > On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: > >> When configuring FPS during probe, assuming a DT node is present for > >> FPS, the code can run into a problem with the switch statements

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-27 Thread Rhyland Klein
On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-27 Thread Rhyland Klein
On 5/12/2016 1:52 PM, Laxman Dewangan wrote: > > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: >> When configuring FPS during probe, assuming a DT node is present for >> FPS, the code can run into a problem with the switch statements in >> max77620_config_fps() and

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Laxman Dewangan
On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: When configuring FPS during probe, assuming a DT node is present for FPS, the code can run into a problem with the switch statements in max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, in the case of chip->chip_id ==

Re: [PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Laxman Dewangan
On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote: When configuring FPS during probe, assuming a DT node is present for FPS, the code can run into a problem with the switch statements in max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, in the case of chip->chip_id ==

[PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Rhyland Klein
When configuring FPS during probe, assuming a DT node is present for FPS, the code can run into a problem with the switch statements in max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, in the case of chip->chip_id == MAX77620, it will set fps_[mix|max]_period but then fall

[PATCH] mfd: max77620: Fix FPS switch statements

2016-05-12 Thread Rhyland Klein
When configuring FPS during probe, assuming a DT node is present for FPS, the code can run into a problem with the switch statements in max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, in the case of chip->chip_id == MAX77620, it will set fps_[mix|max]_period but then fall