Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Lee Jones
On Wed, 25 Sep 2013, Sachin Kamat wrote: > On 25 September 2013 13:07, Wei Yongjun wrote: > > From: Wei Yongjun > > > > - devm_free_irq(>dev, twl6040->irq_ready, twl6040); > > - devm_free_irq(>dev, twl6040->irq_th, twl6040); > > regmap_del_irq_chip(twl6040->irq,

Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Sachin Kamat
On 25 September 2013 13:07, Wei Yongjun wrote: > From: Wei Yongjun > > - devm_free_irq(>dev, twl6040->irq_ready, twl6040); > - devm_free_irq(>dev, twl6040->irq_th, twl6040); > regmap_del_irq_chip(twl6040->irq, twl6040->irq_data); Now that the freeing of irq will happen after

Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Lee Jones
On Wed, 25 Sep 2013, Wei Yongjun wrote: > From: Wei Yongjun > > The devm_request_irq function allocates irq that is released > when a driver detaches. Thus, there is no reason to explicitly > call devm_free_irq in probe or remove functions. > > Signed-off-by: Wei Yongjun > --- >

[PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Wei Yongjun
From: Wei Yongjun The devm_request_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call devm_free_irq in probe or remove functions. Signed-off-by: Wei Yongjun --- drivers/mfd/twl6040.c | 10 ++ 1 file changed, 2 insertions(+),

[PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn The devm_request_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call devm_free_irq in probe or remove functions. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Lee Jones
On Wed, 25 Sep 2013, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The devm_request_irq function allocates irq that is released when a driver detaches. Thus, there is no reason to explicitly call devm_free_irq in probe or remove functions. Signed-off-by: Wei Yongjun

Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Sachin Kamat
On 25 September 2013 13:07, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn - devm_free_irq(client-dev, twl6040-irq_ready, twl6040); - devm_free_irq(client-dev, twl6040-irq_th, twl6040); regmap_del_irq_chip(twl6040-irq,

Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq

2013-09-25 Thread Lee Jones
On Wed, 25 Sep 2013, Sachin Kamat wrote: On 25 September 2013 13:07, Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn - devm_free_irq(client-dev, twl6040-irq_ready, twl6040); - devm_free_irq(client-dev, twl6040-irq_th, twl6040);