From: Fengguang Wu <fengguang...@intel.com>

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface")
CC: Sujeev Dias <sd...@codeaurora.org>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
---

url:
https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

 mhi_boot.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/bus/mhi/core/mhi_boot.c
+++ b/drivers/bus/mhi/core/mhi_boot.c
@@ -504,7 +504,7 @@ void mhi_fw_load_worker(struct work_stru
        if (size > firmware->size)
                size = firmware->size;

-       buf = kmalloc(size, GFP_KERNEL);
+       buf = kmemdup(firmware->data, size, GFP_KERNEL);
        if (!buf) {
                MHI_ERR("Could not allocate memory for image\n");
                release_firmware(firmware);
@@ -512,7 +512,6 @@ void mhi_fw_load_worker(struct work_stru
        }

        /* load sbl image */
-       memcpy(buf, firmware->data, size);
        ret = mhi_fw_load_sbl(mhi_cntrl, buf, size);
        kfree(buf);

Reply via email to