Re: [PATCH] mips: txx9: fix iounmap related issue

2018-09-06 Thread Paul Burton
Hi Ding, On Thu, Sep 06, 2018 at 12:19:19PM +0800, Ding Xiang wrote: > if device_register return error, iounmap should be called, also iounmap > need to call before put_device. > > Signed-off-by: Ding Xiang > --- > arch/mips/txx9/generic/setup.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] mips: txx9: fix iounmap related issue

2018-09-06 Thread Paul Burton
Hi Ding, On Thu, Sep 06, 2018 at 12:19:19PM +0800, Ding Xiang wrote: > if device_register return error, iounmap should be called, also iounmap > need to call before put_device. > > Signed-off-by: Ding Xiang > --- > arch/mips/txx9/generic/setup.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] mips: txx9: fix iounmap related issue

2018-09-06 Thread Atsushi Nemoto
On Thu, 6 Sep 2018 12:19:19 +0800, Ding Xiang wrote: > if device_register return error, iounmap should be called, also iounmap > need to call before put_device. > > Signed-off-by: Ding Xiang > --- > arch/mips/txx9/generic/setup.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [PATCH] mips: txx9: fix iounmap related issue

2018-09-06 Thread Atsushi Nemoto
On Thu, 6 Sep 2018 12:19:19 +0800, Ding Xiang wrote: > if device_register return error, iounmap should be called, also iounmap > need to call before put_device. > > Signed-off-by: Ding Xiang > --- > arch/mips/txx9/generic/setup.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH] mips: txx9: fix iounmap related issue

2018-09-05 Thread Ding Xiang
if device_register return error, iounmap should be called, also iounmap need to call before put_device. Signed-off-by: Ding Xiang --- arch/mips/txx9/generic/setup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup.c

[PATCH] mips: txx9: fix iounmap related issue

2018-09-05 Thread Ding Xiang
if device_register return error, iounmap should be called, also iounmap need to call before put_device. Signed-off-by: Ding Xiang --- arch/mips/txx9/generic/setup.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup.c