Re: [PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-18 Thread Mel Gorman
On Mon, Jan 18, 2021 at 03:41:26PM +0800, Rokudo Yan wrote: > In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= > low_fn) not found. But the high_pfn > is not reset before searching an free area, so when it was used as freepage, > it may from another free area searched

[PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-17 Thread Rokudo Yan
In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= low_fn) not found. But the high_pfn is not reset before searching an free area, so when it was used as freepage, it may from another free area searched before. And move_freelist_head(freelist, freepage) will have

Re: [PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-12 Thread Andrew Morton
On Tue, 12 Jan 2021 17:47:20 +0800 Rokudo Yan wrote: > In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= > low_fn) not found. But the high_pfn > is not reset before searching an free area, so when it was used as freepage, > it may from another free area searched before.

Re: [PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-12 Thread Vlastimil Babka
On 1/12/21 10:47 AM, Rokudo Yan wrote: > In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= > low_fn) not found. But the high_pfn > is not reset before searching an free area, so when it was used as freepage, > it may from another free area searched before. > And

Re: [PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-12 Thread Mel Gorman
On Tue, Jan 12, 2021 at 05:47:20PM +0800, Rokudo Yan wrote: > In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= > low_fn) not found. But the high_pfn > is not reset before searching an free area, so when it was used as freepage, > it may from another free area searched

[PATCH] mm, compaction: move high_pfn to the for loop scope.

2021-01-12 Thread Rokudo Yan
In fast_isolate_freepages, high_pfn will be used if a prefered one(PFN >= low_fn) not found. But the high_pfn is not reset before searching an free area, so when it was used as freepage, it may from another free area searched before. And move_freelist_head(freelist, freepage) will have