Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Thu, 25 Feb 2016, Chen Yucong wrote: > > Please explain how the conversion from KERN_DEBUG to KERN_INFO level is > > better? > > Like __offline_pages(), printk() in online_pages() is used for reporting > an failed addition rather than debug information. > Another reason is that pr_debug() is

Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Thu, 25 Feb 2016, Chen Yucong wrote: > > Please explain how the conversion from KERN_DEBUG to KERN_INFO level is > > better? > > Like __offline_pages(), printk() in online_pages() is used for reporting > an failed addition rather than debug information. > Another reason is that pr_debug() is

Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Wed, 2016-02-24 at 13:33 -0800, David Rientjes wrote: > On Wed, 24 Feb 2016, Chen Yucong wrote: > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index c832ef3..e4b6dec3 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1059,10 +1059,9 @@ int __ref

Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Wed, 2016-02-24 at 13:33 -0800, David Rientjes wrote: > On Wed, 24 Feb 2016, Chen Yucong wrote: > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index c832ef3..e4b6dec3 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1059,10 +1059,9 @@ int __ref

Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Wed, 24 Feb 2016, Chen Yucong wrote: > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index c832ef3..e4b6dec3 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1059,10 +1059,9 @@ int __ref online_pages(unsigned long pfn, unsigned > long nr_pages, int online_typ >

Re: [PATCH] mm, memory hotplug: print more failure information for online_pages

On Wed, 24 Feb 2016, Chen Yucong wrote: > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index c832ef3..e4b6dec3 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1059,10 +1059,9 @@ int __ref online_pages(unsigned long pfn, unsigned > long nr_pages, int online_typ >

[PATCH] mm, memory hotplug: print more failure information for online_pages

online_pages() simply returns an error value if memory_notify(MEM_GOING_ONLINE, ) return a value that is not what we want for successfully onlining target pages. This patch arms to print more failure information like offline_pages() in online_pages. And this patch also converts printk(KERN_) to

[PATCH] mm, memory hotplug: print more failure information for online_pages

online_pages() simply returns an error value if memory_notify(MEM_GOING_ONLINE, ) return a value that is not what we want for successfully onlining target pages. This patch arms to print more failure information like offline_pages() in online_pages. And this patch also converts printk(KERN_) to