Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 10:51am, Michal Hocko wrote: > > I just tested the movable zone checking yesterday, will add your > > previous check back, then test again. I believe the result will be > > positive. Will udpate once done. > > THere is no need to retest with that patch for your movable node setup.

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 10:51am, Michal Hocko wrote: > > I just tested the movable zone checking yesterday, will add your > > previous check back, then test again. I believe the result will be > > positive. Will udpate once done. > > THere is no need to retest with that patch for your movable node setup.

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 17:16:24, Baoquan He wrote: [...] > Not sure if there are any scenario or use cases to cover those newly added > checking other movable zone checking. Surely, I have no objection to > adding them. But the two patches are separate issues, they have no > dependency on each other.

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 17:16:24, Baoquan He wrote: [...] > Not sure if there are any scenario or use cases to cover those newly added > checking other movable zone checking. Surely, I have no objection to > adding them. But the two patches are separate issues, they have no > dependency on each other.

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 05:16pm, Baoquan He wrote: > On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > > It failed. Paste the log and patch diff here, please help check > > > > > > > if I made > > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > > > The retry

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 05:16pm, Baoquan He wrote: > On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > > It failed. Paste the log and patch diff here, please help check > > > > > > > if I made > > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > > > The retry

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > It failed. Paste the log and patch diff here, please help check if > > > > > > I made > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > The retry patch is obviously still racy, it just makes the race

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Baoquan He
On 11/06/18 at 09:28am, Michal Hocko wrote: > > > > > > It failed. Paste the log and patch diff here, please help check if > > > > > > I made > > > > > > any mistake on manual code change. The log is at bottom. > > > > > > > > > > The retry patch is obviously still racy, it just makes the race

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 08:22:16, Baoquan He wrote: > On 11/05/18 at 06:10pm, Michal Hocko wrote: > > On Mon 05-11-18 22:23:08, Baoquan He wrote: > > > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > > > Hi Michal, > > > > > > > > > > On 11/05/18 at

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-06 Thread Michal Hocko
On Tue 06-11-18 08:22:16, Baoquan He wrote: > On 11/05/18 at 06:10pm, Michal Hocko wrote: > > On Mon 05-11-18 22:23:08, Baoquan He wrote: > > > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > > > Hi Michal, > > > > > > > > > > On 11/05/18 at

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 06:10pm, Michal Hocko wrote: > On Mon 05-11-18 22:23:08, Baoquan He wrote: > > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > > Hi Michal, > > > > > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > > > > > Or

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 06:10pm, Michal Hocko wrote: > On Mon 05-11-18 22:23:08, Baoquan He wrote: > > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > > Hi Michal, > > > > > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > > > > > Or

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 22:23:08, Baoquan He wrote: > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > Hi Michal, > > > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > > > Or something like this. Ugly as hell, no question about that. I also

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 22:23:08, Baoquan He wrote: > On 11/05/18 at 01:38pm, Michal Hocko wrote: > > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > > Hi Michal, > > > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > > > Or something like this. Ugly as hell, no question about that. I also

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 01:38pm, Michal Hocko wrote: > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > Hi Michal, > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > Or something like this. Ugly as hell, no question about that. I also > > > have to think about this some more to convince

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 01:38pm, Michal Hocko wrote: > On Mon 05-11-18 18:25:20, Baoquan He wrote: > > Hi Michal, > > > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > > > Or something like this. Ugly as hell, no question about that. I also > > > have to think about this some more to convince

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 18:25:20, Baoquan He wrote: > Hi Michal, > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > Or something like this. Ugly as hell, no question about that. I also > > have to think about this some more to convince myself this will not > > result in an endless loop under some

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 18:25:20, Baoquan He wrote: > Hi Michal, > > On 11/05/18 at 10:28am, Michal Hocko wrote: > > > > Or something like this. Ugly as hell, no question about that. I also > > have to think about this some more to convince myself this will not > > result in an endless loop under some

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
Hi Michal, On 11/05/18 at 10:28am, Michal Hocko wrote: > > Or something like this. Ugly as hell, no question about that. I also > have to think about this some more to convince myself this will not > result in an endless loop under some situations. It failed. Paste the log and patch diff here,

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
Hi Michal, On 11/05/18 at 10:28am, Michal Hocko wrote: > > Or something like this. Ugly as hell, no question about that. I also > have to think about this some more to convince myself this will not > result in an endless loop under some situations. It failed. Paste the log and patch diff here,

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 10:28am, Michal Hocko wrote: > On Mon 05-11-18 10:14:07, Michal Hocko wrote: > > Maybe we can add a retry for movable zone pages. > > Or something like this. Ugly as hell, no question about that. I also > have to think about this some more to convince myself this will not > result

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 10:28am, Michal Hocko wrote: > On Mon 05-11-18 10:14:07, Michal Hocko wrote: > > Maybe we can add a retry for movable zone pages. > > Or something like this. Ugly as hell, no question about that. I also > have to think about this some more to convince myself this will not > result

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 17:26:18, Baoquan He wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index a919ba5..021e39d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7824,7 +7824,8 @@ bool has_unmovable_pages(struct zone *zone, struct page > *page, int count, >

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 17:26:18, Baoquan He wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index a919ba5..021e39d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7824,7 +7824,8 @@ bool has_unmovable_pages(struct zone *zone, struct page > *page, int count, >

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 10:14:07, Michal Hocko wrote: > Maybe we can add a retry for movable zone pages. Or something like this. Ugly as hell, no question about that. I also have to think about this some more to convince myself this will not result in an endless loop under some situations. diff --git

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 10:14:07, Michal Hocko wrote: > Maybe we can add a retry for movable zone pages. Or something like this. Ugly as hell, no question about that. I also have to think about this some more to convince myself this will not result in an endless loop under some situations. diff --git

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 10:14am, Michal Hocko wrote: > On Mon 05-11-18 08:20:09, Baoquan He wrote: > > Hi Michal, > > > > On 11/02/18 at 04:55pm, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > > > has_unmovable_pages more

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Baoquan He
On 11/05/18 at 10:14am, Michal Hocko wrote: > On Mon 05-11-18 08:20:09, Baoquan He wrote: > > Hi Michal, > > > > On 11/02/18 at 04:55pm, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > > > has_unmovable_pages more

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 08:20:09, Baoquan He wrote: > Hi Michal, > > On 11/02/18 at 04:55pm, Michal Hocko wrote: > > From: Michal Hocko > > > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > > has_unmovable_pages more robust") is causing memory offlining failures > > on a

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 08:20:09, Baoquan He wrote: > Hi Michal, > > On 11/02/18 at 04:55pm, Michal Hocko wrote: > > From: Michal Hocko > > > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > > has_unmovable_pages more robust") is causing memory offlining failures > > on a

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-04 Thread Baoquan He
Hi Michal, On 11/02/18 at 04:55pm, Michal Hocko wrote: > From: Michal Hocko > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > has_unmovable_pages more robust") is causing memory offlining failures > on a movable node. After a further debugging it turned out that >

Re: [PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-04 Thread Baoquan He
Hi Michal, On 11/02/18 at 04:55pm, Michal Hocko wrote: > From: Michal Hocko > > Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make > has_unmovable_pages more robust") is causing memory offlining failures > on a movable node. After a further debugging it turned out that >

[PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-02 Thread Michal Hocko
From: Michal Hocko Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make has_unmovable_pages more robust") is causing memory offlining failures on a movable node. After a further debugging it turned out that has_unmovable_pages fails prematurely because it stumbles over off-LRU

[PATCH] mm, memory_hotplug: teach has_unmovable_pages about of LRU migrateable pages

2018-11-02 Thread Michal Hocko
From: Michal Hocko Baoquan He has noticed that 15c30bc09085 ("mm, memory_hotplug: make has_unmovable_pages more robust") is causing memory offlining failures on a movable node. After a further debugging it turned out that has_unmovable_pages fails prematurely because it stumbles over off-LRU